From: Adrian Bunk <bunk@kernel.org>
To: Paul Moore <paul.moore@hp.com>
Cc: James Morris <jmorris@namei.org>,
sds@tycho.nsa.gov, eparis@parisplace.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] security/selinux/netlabel.c: fix double free
Date: Tue, 29 Jan 2008 00:35:40 +0200 [thread overview]
Message-ID: <20080128223540.GN8767@does.not.exist> (raw)
In-Reply-To: <200801281723.46273.paul.moore@hp.com>
On Mon, Jan 28, 2008 at 05:23:46PM -0500, Paul Moore wrote:
> On Monday 28 January 2008 5:09:38 pm Adrian Bunk wrote:
> > This patch fixes a double free (security_netlbl_sid_to_secattr()
> > already calls netlbl_secattr_destroy() when it returns !0) introduced
> > by commit 45c950e0f839fded922ebc0bfd59b1081cc71b70 and spotted by the
> > Coverity checker.
>
> Hi Adrian,
Hi Paul,
> Thanks for finding this mistake, however, I'd rather see it fixed by
> removing the netlbl_secattr_destroy() call in
> security_netlbl_sid_to_secattr() as it really shouldn't be there
> anymore. We moved the matching _init() call into
> selinux_netlbl_sock_setsid() and I'd like to see the _init() and
> _destroy() calls done in the same function. I can push a revised patch
> for this if you would prefer, otherwise I'll be happy to ack an updated
> version ...
doing the patch is trivial but you are able to write a better
changelog for it - just push a revised patch.
> paul moore
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-01-28 22:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 22:09 [2.6 patch] security/selinux/netlabel.c: fix double free Adrian Bunk
2008-01-28 22:23 ` Paul Moore
2008-01-28 22:35 ` Adrian Bunk [this message]
2008-01-28 22:39 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128223540.GN8767@does.not.exist \
--to=bunk@kernel.org \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).