From: Paul Moore <paul.moore@hp.com>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org, selinux@tycho.nsa.gov, stable@kernel.org,
bunk@kernel.org, jmorris@namei.org
Subject: [PATCH] SELinux: Fix double free in selinux_netlbl_sock_setsid()
Date: Mon, 28 Jan 2008 21:20:26 -0500 [thread overview]
Message-ID: <20080129022026.7930.18782.stgit@flek.lan> (raw)
As pointed out by Adrian Bunk, commit 45c950e0f839fded922ebc0bfd59b1081cc71b70
caused a double-free when security_netlbl_sid_to_secattr() fails. This patch
fixes this by removing the netlbl_secattr_destroy() call from that function
since we are already releasing the secattr memory in
selinux_netlbl_sock_setsid().
Signed-off-by: Paul Moore <paul.moore@hp.com>
---
security/selinux/ss/services.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index 4bf715d..3a16aba 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -2629,7 +2629,6 @@ int security_netlbl_sid_to_secattr(u32 sid, struct netlbl_lsm_secattr *secattr)
netlbl_sid_to_secattr_failure:
POLICY_RDUNLOCK;
- netlbl_secattr_destroy(secattr);
return rc;
}
#endif /* CONFIG_NETLABEL */
next reply other threads:[~2008-01-29 2:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 2:20 Paul Moore [this message]
2008-01-29 3:51 ` [PATCH] SELinux: Fix double free in selinux_netlbl_sock_setsid() David Miller
2008-01-29 17:13 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129022026.7930.18782.stgit@flek.lan \
--to=paul.moore@hp.com \
--cc=bunk@kernel.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).