From: Jarek Poplawski <jarkao2@gmail.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Joonwoo Park <joonwpark81@gmail.com>
Subject: Re: [PATCHv2 2.6.24] fib: fix route replacement, fib_info is shared
Date: Tue, 29 Jan 2008 10:10:30 +0100 [thread overview]
Message-ID: <20080129091030.GB1624@ff.dom.local> (raw)
In-Reply-To: <20080129084915.GA1624@ff.dom.local>
On Tue, Jan 29, 2008 at 09:49:15AM +0100, Jarek Poplawski wrote:
> On Tue, Jan 29, 2008 at 02:30:47AM +0200, Julian Anastasov wrote:
...
> > fa_match is some existing alias that matches all new parameters.
> > As NLM_F_REPLACE changes the first alternative route for
> > tos+priority if fa_match == fa_first (we are replacing alias that
> > matches all parameters) we return 0, only that routing cache is not
> > flushed - nothing is replaced/changed. So, "fa == fa_match" means
> > "replace will not change existing parameters", return 0 as this is
> > not an error.
>
> Probably I miss something, but what parameters do we change if
> (fa_match) && (fa != fa_match)? Isn't this "goto out" in any case?
OOPS! You mean change is needed, but we can't do this! (I'm so slow...)
All correct!
Thanks again,
Jarek P.
next prev parent reply other threads:[~2008-01-29 9:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 12:41 [PATCHv2 2.6.24] fib: fix route replacement, fib_info is shared Julian Anastasov
2008-01-27 23:20 ` Jarek Poplawski
2008-01-28 8:33 ` Jarek Poplawski
2008-01-28 8:36 ` Jarek Poplawski
2008-01-28 8:56 ` Jarek Poplawski
2008-01-29 0:30 ` Julian Anastasov
2008-01-29 8:49 ` Jarek Poplawski
2008-01-29 9:10 ` Jarek Poplawski [this message]
2008-01-29 9:52 ` Jarek Poplawski
2008-02-02 10:56 ` Julian Anastasov
2008-02-02 19:21 ` Jarek Poplawski
2008-01-29 5:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129091030.GB1624@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=joonwpark81@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).