From: Francois Romieu <romieu@fr.zoreil.com>
To: maximilian attems <max@stro.at>
Cc: netdev@vger.kernel.org
Subject: Re: sis190 build breakage
Date: Tue, 29 Jan 2008 23:27:48 +0100 [thread overview]
Message-ID: <20080129222748.GD15445@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20080129222719.GS1446@baikonur.stro.at>
maximilian attems <max@stro.at> :
[...]
> probably i should to get interesting info.
Don't bother.
$ less +/devinitdata Documentation/pci.txt
[...]
Tips on when/where to use the above attributes:
o The module_init()/module_exit() functions (and all
initialization functions called _only_ from these)
should be marked __init/__exit.
o Do not mark the struct pci_driver.
o The ID table array should be marked __devinitdata.
Could our documentation be wrong ?
diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
index b570402..2e9e88b 100644
--- a/drivers/net/sis190.c
+++ b/drivers/net/sis190.c
@@ -326,7 +326,7 @@ static const struct {
{ "SiS 191 PCI Gigabit Ethernet adapter" },
};
-static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
+static struct pci_device_id sis190_pci_tbl[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
{ 0, },
next prev parent reply other threads:[~2008-01-29 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 21:50 sis190 build breakage maximilian attems
2008-01-29 22:03 ` Francois Romieu
2008-01-29 22:27 ` maximilian attems
2008-01-29 22:27 ` Francois Romieu [this message]
2008-01-29 23:12 ` maximilian attems
2008-01-30 0:42 ` Randy Dunlap
2008-01-30 3:28 ` Sam Ravnborg
2008-01-30 8:22 ` Jeff Garzik
2008-01-30 9:13 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129222748.GD15445@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=max@stro.at \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).