Re: sis190 build breakage

[maximilian attems <max@stro.at>]

On Tue, Jan 29, 2008 at 11:27:48PM +0100, Francois Romieu wrote:
> maximilian attems <max@stro.at> :
> [...]
> > probably i should to get interesting info.
> 
> Don't bother.
> 
> $ less +/devinitdata Documentation/pci.txt
> [...]
> Tips on when/where to use the above attributes:
>         o The module_init()/module_exit() functions (and all
>           initialization functions called _only_ from these)
>           should be marked __init/__exit.
> 
>         o Do not mark the struct pci_driver.
> 
>         o The ID table array should be marked __devinitdata.
>
> Could our documentation be wrong ?

yep that was what i had in mind, so i was a bit baffled..

randy any insight?
 
> 
> diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
> index b570402..2e9e88b 100644
> --- a/drivers/net/sis190.c
> +++ b/drivers/net/sis190.c
> @@ -326,7 +326,7 @@ static const struct {
>  	{ "SiS 191 PCI Gigabit Ethernet adapter" },
>  };
>  
> -static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
> +static struct pci_device_id sis190_pci_tbl[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
>  	{ 0, },

thanks for quick fix.