From: Sam Ravnborg <sam@ravnborg.org>
To: Jeff Garzik <jeff@garzik.org>, Jan Beulich <jbeulich@novell.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
maximilian attems <max@stro.at>,
netdev@vger.kernel.org
Subject: Re: sis190 build breakage
Date: Wed, 30 Jan 2008 10:13:27 +0100 [thread overview]
Message-ID: <20080130091327.GA20178@uranus.ravnborg.org> (raw)
In-Reply-To: <47A033DB.3070608@garzik.org>
On Wed, Jan 30, 2008 at 03:22:51AM -0500, Jeff Garzik wrote:
> Sam Ravnborg wrote:
> >On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote:
> >>maximilian attems <max@stro.at> :
> >>> CC [M] drivers/net/sis190.o
> >>> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type
> >>> conflict
> >>> make[5]: *** [drivers/net/sis190.o] Error 1
> >>>
> >>>gcc --version
> >>>gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)
> >
> >Looks like a bug where __initdata has been used
> >for const data.
> >Searching:
> >static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev,
> > struct net_device *dev)
> >{
> > static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
> > struct sis190_private *tp = netdev_priv(dev);
> > struct pci_dev *isa_bridge;
> > u8 reg, tmp8;
> >
> >Try to change this is __initconst and it should be fixed.
>
> We have __initconst now?
>
> Three cheers, and a beer, to whomever did that...
I will hand over the cheers to Jan Beulich and drink the beer myself ;-)
Sam
prev parent reply other threads:[~2008-01-30 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 21:50 sis190 build breakage maximilian attems
2008-01-29 22:03 ` Francois Romieu
2008-01-29 22:27 ` maximilian attems
2008-01-29 22:27 ` Francois Romieu
2008-01-29 23:12 ` maximilian attems
2008-01-30 0:42 ` Randy Dunlap
2008-01-30 3:28 ` Sam Ravnborg
2008-01-30 8:22 ` Jeff Garzik
2008-01-30 9:13 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080130091327.GA20178@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=jbeulich@novell.com \
--cc=jeff@garzik.org \
--cc=max@stro.at \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).