* Strange commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5
@ 2008-01-30 17:55 Adrian Bunk
2008-01-31 10:27 ` Pavel Emelyanov
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-01-30 17:55 UTC (permalink / raw)
To: Pavel Emelyanov, David S. Miller; +Cc: netdev, linux-kernel
Commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5
("[RAW]: Consolidate proc interface.") did not only change raw6_seq_ops
(including adding 3 EXPORT_SYMBOL_GPL's to net/ipv4/raw.c for accessing
functions from there), it also removed the only user of raw6_seq_ops...
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Strange commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5
2008-01-30 17:55 Strange commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5 Adrian Bunk
@ 2008-01-31 10:27 ` Pavel Emelyanov
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Emelyanov @ 2008-01-31 10:27 UTC (permalink / raw)
To: Adrian Bunk, David S. Miller; +Cc: netdev, linux-kernel, Denis Lunev
Adrian Bunk wrote:
> Commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5
> ("[RAW]: Consolidate proc interface.") did not only change raw6_seq_ops
> (including adding 3 EXPORT_SYMBOL_GPL's to net/ipv4/raw.c for accessing
> functions from there), it also removed the only user of raw6_seq_ops...
The commit is not strange it is wrong :( Sorry David, when I checked
the according proc files, I saw that both files show sockets, but
overlooked that the raw6 one shows the ipv4 part of the ipv6 socket.
Denis noticed that this morning and has already prepared a fix.
So please, do not revert the commit, the fix will be at your mailbox today.
Thanks, Adrian.
> cu
> Adrian
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-31 10:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-30 17:55 Strange commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5 Adrian Bunk
2008-01-31 10:27 ` Pavel Emelyanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).