From: David Miller <davem@davemloft.net>
To: jim@jtan.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: update MSS even if MTU is unchanged
Date: Thu, 31 Jan 2008 16:37:36 -0800 (PST) [thread overview]
Message-ID: <20080131.163736.46142971.davem@davemloft.net> (raw)
In-Reply-To: <20080121220248.GA25284@jim.sh>
From: Jim Paris <jim@jtan.com>
Date: Mon, 21 Jan 2008 17:02:48 -0500
> This is needed because in ndisc.c, we have:
>
> static void ndisc_router_discovery(struct sk_buff *skb)
> {
> // ...
> if (ndopts.nd_opts_mtu) {
> // ...
> if (rt)
> rt->u.dst.metrics[RTAX_MTU-1] = mtu;
>
> rt6_mtu_change(skb->dev, mtu);
> // ...
> }
>
> Since the mtu is set directly here, rt6_mtu_change_route thinks that
> it is unchanged, and so it fails to update the MSS accordingly. This
> patch lets rt6_mtu_change_route still update MSS if old_mtu == new_mtu.
>
> Signed-off-by: Jim Paris <jim@jtan.com>
This seems ok, patch applied, thanks.
prev parent reply other threads:[~2008-02-01 0:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 10:52 IPv6 problems (mtu is less than advmss?) Jim Paris
2008-01-21 22:02 ` [PATCH] ipv6: update MSS even if MTU is unchanged Jim Paris
2008-02-01 0:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131.163736.46142971.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jim@jtan.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).