From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Petko Manolov <petkan@nucleusys.com>
Cc: netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: rtl8150: use default MTU of 1500
Date: Thu, 31 Jan 2008 17:05:01 +0100 [thread overview]
Message-ID: <20080131160501.GA24019@xi.wantstofly.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0801311741400.4476@bender.nucleusys.com>
On Thu, Jan 31, 2008 at 05:42:34PM +0200, Petko Manolov wrote:
> > The RTL8150 driver uses an MTU of 1540 by default, which causes a
> > bunch of problems -- it prevents booting from NFS root, for one.
>
> Agreed, although it is a bit strange how this particular bug has
> sneaked up for so long...
I posted this patch sometime in 2006, and you asked me a question
about it then (why we don't just set RTL8150_MTU to 1500 -- the
answer would be that RTL8150_MTU is used in a couple more places
in the driver, including for allocing skbuffs), but I failed to
follow up to that question at the time, which is why I assume it got
dropped.
I have been carrying the patch in my own tree since then, and only
noticed recently that the patch never made it upstream.
cheers,
Lennert
> >Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
> >Cc: Petko Manolov <petkan@nucleusys.com>
> >
> >--- linux-2.6.24-git7.orig/drivers/net/usb/rtl8150.c 2008-01-24
> >23:58:37.000000000 +0100
> >+++ linux-2.6.24-git7/drivers/net/usb/rtl8150.c 2008-01-30
> >20:29:00.000000000 +0100
> >@@ -925,9 +925,8 @@
> > netdev->hard_start_xmit = rtl8150_start_xmit;
> > netdev->set_multicast_list = rtl8150_set_multicast;
> > netdev->set_mac_address = rtl8150_set_mac_address;
> > netdev->get_stats = rtl8150_netdev_stats;
> >- netdev->mtu = RTL8150_MTU;
> > SET_ETHTOOL_OPS(netdev, &ops);
> > dev->intr_interval = 100; /* 100ms */
> >
> > if (!alloc_all_urbs(dev)) {
> >
next prev parent reply other threads:[~2008-01-31 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 19:37 rtl8150: use default MTU of 1500 Lennert Buytenhek
2008-01-31 15:42 ` Petko Manolov
2008-01-31 16:05 ` Lennert Buytenhek [this message]
2008-02-01 18:41 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080131160501.GA24019@xi.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=petkan@nucleusys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).