From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH] Disable TSO for non standard qdiscs Date: Fri, 1 Feb 2008 06:01:46 +0100 Message-ID: <20080201050146.GD10720@one.firstfloor.org> References: <20080131183322.GA4671@one.firstfloor.org> <47A20CDC.5090104@trash.net> <20080131183735.GC4671@one.firstfloor.org> <20080131100846.00934e25@extreme> <20080131185328.GD4671@one.firstfloor.org> <47A211A0.1040502@trash.net> <20080131190125.GE4671@one.firstfloor.org> <20080131193406.GH4671@one.firstfloor.org> <47A230A8.7080100@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andi Kleen , "Waskiewicz Jr, Peter P" , Patrick McHardy , Stephen Hemminger , netdev@vger.kernel.org To: Jarek Poplawski Return-path: Received: from one.firstfloor.org ([213.235.205.2]:53914 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753751AbYBAE1S (ORCPT ); Thu, 31 Jan 2008 23:27:18 -0500 Content-Disposition: inline In-Reply-To: <47A230A8.7080100@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jan 31, 2008 at 09:33:44PM +0100, Jarek Poplawski wrote: > Andi Kleen wrote, On 01/31/2008 08:34 PM: > > >> TSO by nature is bursty. But disabling TSO without the option of having > >> it on or off to me seems to aggressive. If someone is using a qdisc > >> that TSO is interfering with the effectiveness of the traffic shaping, > >> then they should turn off TSO via ethtool on the target device. Some > > > > The philosophical problem I have with this suggestion is that I expect > > that the large majority of users will be more happy with disabled TSO > > if they use non standard qdiscs and defaults that do not fit > > the majority use case are bad. > > > If you mean the large majority of the large minority of users, who use > non standard qdiscs - I agree - this is really the philosophical problem! [....] Sorry if you had a point in this email I missed it. -Andi