netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
	Patrick McHardy <kaber@trash.net>,
	Andi Kleen <andi@firstfloor.org>, Glen Turner <gdt@gdt.id.au>,
	netdev@vger.kernel.org
Subject: Re: [PATCH] Disable TSO for non standard qdiscs
Date: Fri, 1 Feb 2008 09:24:39 -0800	[thread overview]
Message-ID: <20080201092439.7c588ef5@extreme> (raw)
In-Reply-To: <20080201143421.GB16630@one.firstfloor.org>

On Fri, 1 Feb 2008 15:34:21 +0100
Andi Kleen <andi@firstfloor.org> wrote:

> > The TSO defer logic is based on your congestion window and current
> > window size.  So the actual frame sizes hitting your NIC attached to
> > your DSL probably aren't anywhere near 64KB, but probably more in line
> > with whatever your window size is for DSL.
> 
> DSL windows can be quite large because a lot of DSL lines have a quite
> long latency due to error correction. And with ADSL2 we have upto 16Mbit
> now.
> 
> > I think we're having more of a disagreement of what is considered the
> > "normal case" user.  If you are on a slow link, such as a DSL/cable
> > line, your TCP window/congestion window aren't going to be big enough to
> > generate large TSO's, so what is the issue?  But disabling TSO, say on a
> 
> 64k TSOs are likely even with DSL. Anyways even with smaller TSOs the
> change still makes sense because each increase makes packet scheduling
> less smooth.
> 
> -Andi

I wish there was a per-device setting for the max-size of TSO burst.


-- 
Stephen Hemminger <stephen.hemminger@vyatta.com>

  reply	other threads:[~2008-02-01 17:25 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31 12:46 [PATCH] Disable TSO for non standard qdiscs Andi Kleen
2008-01-31 17:23 ` Stephen Hemminger
2008-01-31 18:33   ` Andi Kleen
2008-01-31 18:01     ` Patrick McHardy
2008-01-31 18:37       ` Andi Kleen
2008-01-31 18:08         ` Stephen Hemminger
2008-01-31 18:11           ` Patrick McHardy
2008-01-31 18:53           ` Andi Kleen
2008-01-31 18:21             ` Patrick McHardy
2008-01-31 19:01               ` Andi Kleen
2008-01-31 18:47                 ` Waskiewicz Jr, Peter P
2008-01-31 19:34                   ` Andi Kleen
2008-01-31 19:39                     ` Waskiewicz Jr, Peter P
2008-01-31 23:10                       ` Arnaldo Carvalho de Melo
2008-01-31 23:42                         ` Waskiewicz Jr, Peter P
2008-02-01  4:26                           ` Patrick McHardy
2008-02-01  4:35                           ` Andi Kleen
2008-02-01  4:36                         ` Andi Kleen
2008-01-31 20:33                     ` Jarek Poplawski
2008-01-31 23:04                       ` Jarek Poplawski
2008-02-01  7:42                         ` Jarek Poplawski
2008-02-01  9:28                           ` Waskiewicz Jr, Peter P
2008-02-01 21:47                             ` Jarek Poplawski
2008-02-01  5:01                       ` Andi Kleen
2008-02-01  6:35                     ` Glen Turner
2008-02-01  6:46                       ` Patrick McHardy
2008-02-01  7:46                       ` Andi Kleen
2008-02-01  7:25                         ` Patrick McHardy
2008-02-01  9:37                           ` Waskiewicz Jr, Peter P
2008-02-01  9:56                             ` Patrick McHardy
2008-02-01 12:06                               ` jamal
2008-02-01 19:02                                 ` Waskiewicz Jr, Peter P
2008-02-01 22:56                                 ` Jarek Poplawski
2008-02-02  1:51                                   ` Waskiewicz Jr, Peter P
2008-02-02  5:20                                 ` Andi Kleen
2008-02-01 14:34                             ` Andi Kleen
2008-02-01 17:24                               ` Stephen Hemminger [this message]
2008-01-31 18:48                 ` Patrick McHardy
2008-02-02 22:57             ` Herbert Xu
2008-02-03  9:35               ` Andi Kleen
2008-01-31 18:26 ` Rick Jones
2008-01-31 19:03   ` Andi Kleen
2008-01-31 18:35     ` Rick Jones
2008-01-31 19:25       ` Andi Kleen
2008-01-31 19:14         ` Rick Jones
2008-02-01  1:04           ` Andy Furniss
2008-02-01  4:31           ` Andi Kleen
2008-02-02 22:59             ` Herbert Xu
2008-02-01 21:58     ` Rick Jones
2008-02-02  4:10       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080201092439.7c588ef5@extreme \
    --to=shemminger@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=gdt@gdt.id.au \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).