From: Jarek Poplawski <jarkao2@gmail.com>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Patrick McHardy <kaber@trash.net>,
Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] Disable TSO for non standard qdiscs
Date: Fri, 1 Feb 2008 22:47:39 +0100 [thread overview]
Message-ID: <20080201214738.GA3071@ami.dom.local> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC32904737A40@orsmsx414.amr.corp.intel.com>
On Fri, Feb 01, 2008 at 01:28:15AM -0800, Waskiewicz Jr, Peter P wrote:
...
> The TCP layer will generate TSO packets based on the kernel socket
> features associated with the flow. So if you have two devices, one
> supporting TSO, the other not, then the flows associated with the
> non-TSO device will not have their packets built for TSO. This has no
> bearing on the device supporting TSO, which its feature flags will
> propogate into the kernel socket for that flow, and cause any TCP flows
> to that device to be TSO packets. So in a nutshell, disabling TSO is on
> a per-device level, not a global switch.
Fine, but I was rather wondering if there could be something more in
the idea of this patch that can't be done with ethtool. And I don't
think qdisc code currently treats or should treat TCP special.
Jarek P.
next prev parent reply other threads:[~2008-02-01 21:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 12:46 [PATCH] Disable TSO for non standard qdiscs Andi Kleen
2008-01-31 17:23 ` Stephen Hemminger
2008-01-31 18:33 ` Andi Kleen
2008-01-31 18:01 ` Patrick McHardy
2008-01-31 18:37 ` Andi Kleen
2008-01-31 18:08 ` Stephen Hemminger
2008-01-31 18:11 ` Patrick McHardy
2008-01-31 18:53 ` Andi Kleen
2008-01-31 18:21 ` Patrick McHardy
2008-01-31 19:01 ` Andi Kleen
2008-01-31 18:47 ` Waskiewicz Jr, Peter P
2008-01-31 19:34 ` Andi Kleen
2008-01-31 19:39 ` Waskiewicz Jr, Peter P
2008-01-31 23:10 ` Arnaldo Carvalho de Melo
2008-01-31 23:42 ` Waskiewicz Jr, Peter P
2008-02-01 4:26 ` Patrick McHardy
2008-02-01 4:35 ` Andi Kleen
2008-02-01 4:36 ` Andi Kleen
2008-01-31 20:33 ` Jarek Poplawski
2008-01-31 23:04 ` Jarek Poplawski
2008-02-01 7:42 ` Jarek Poplawski
2008-02-01 9:28 ` Waskiewicz Jr, Peter P
2008-02-01 21:47 ` Jarek Poplawski [this message]
2008-02-01 5:01 ` Andi Kleen
2008-02-01 6:35 ` Glen Turner
2008-02-01 6:46 ` Patrick McHardy
2008-02-01 7:46 ` Andi Kleen
2008-02-01 7:25 ` Patrick McHardy
2008-02-01 9:37 ` Waskiewicz Jr, Peter P
2008-02-01 9:56 ` Patrick McHardy
2008-02-01 12:06 ` jamal
2008-02-01 19:02 ` Waskiewicz Jr, Peter P
2008-02-01 22:56 ` Jarek Poplawski
2008-02-02 1:51 ` Waskiewicz Jr, Peter P
2008-02-02 5:20 ` Andi Kleen
2008-02-01 14:34 ` Andi Kleen
2008-02-01 17:24 ` Stephen Hemminger
2008-01-31 18:48 ` Patrick McHardy
2008-02-02 22:57 ` Herbert Xu
2008-02-03 9:35 ` Andi Kleen
2008-01-31 18:26 ` Rick Jones
2008-01-31 19:03 ` Andi Kleen
2008-01-31 18:35 ` Rick Jones
2008-01-31 19:25 ` Andi Kleen
2008-01-31 19:14 ` Rick Jones
2008-02-01 1:04 ` Andy Furniss
2008-02-01 4:31 ` Andi Kleen
2008-02-02 22:59 ` Herbert Xu
2008-02-01 21:58 ` Rick Jones
2008-02-02 4:10 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080201214738.GA3071@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=andi@firstfloor.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).