netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Rick Jones <rick.jones2@hp.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] Disable TSO for non standard qdiscs
Date: Sat, 2 Feb 2008 05:10:05 +0100	[thread overview]
Message-ID: <20080202041005.GB12644@one.firstfloor.org> (raw)
In-Reply-To: <47A39606.4090401@hp.com>

On Fri, Feb 01, 2008 at 01:58:30PM -0800, Rick Jones wrote:
> >>Does this also imply that JumboFrames interacts badly with these qdiscs? 
> >>Or IPoIB with its 65000ish byte MTU?
> >
> >
> >Correct. Of course it is always relative to the link speed. So if your
> >link is 10x faster and your packets 10x bigger you can get similarly
> >smooth shaping.
> 
> If the later-in-thread mentioned person shaping for their DSL line 
> happens to have enabled JumboFrames on their GbE network, will/should 
> the qdisc negate that? 

I don't think so, mostly because jumbo frames are not enabled by
default.  I'm only concerned about usable defaults there -- if you
set non default options you should certainly know what you're doing.

There are other reasons to not use jumbo frames anyways; e.g. a lot 
of cards still do not support SG for them but only process 
them as a single continuous buffer in memory so you often run 
into memory fragmentation problems.

> Or is the qdisc currently assuming that the 
> remote end of the DSL will have asked for a smaller MSS?

First there are lots of different qdiscs that all do different things.
Take a look at net/sched/*. Then they usually don't strictly require particular
MTUs (or know anything about MSS), but tend to work better with smaller
MTUs because that allows more choices in packet scheduling.  Generally
the larger your packets the less they can be scheduled.

-Andi


      reply	other threads:[~2008-02-02  3:35 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31 12:46 [PATCH] Disable TSO for non standard qdiscs Andi Kleen
2008-01-31 17:23 ` Stephen Hemminger
2008-01-31 18:33   ` Andi Kleen
2008-01-31 18:01     ` Patrick McHardy
2008-01-31 18:37       ` Andi Kleen
2008-01-31 18:08         ` Stephen Hemminger
2008-01-31 18:11           ` Patrick McHardy
2008-01-31 18:53           ` Andi Kleen
2008-01-31 18:21             ` Patrick McHardy
2008-01-31 19:01               ` Andi Kleen
2008-01-31 18:47                 ` Waskiewicz Jr, Peter P
2008-01-31 19:34                   ` Andi Kleen
2008-01-31 19:39                     ` Waskiewicz Jr, Peter P
2008-01-31 23:10                       ` Arnaldo Carvalho de Melo
2008-01-31 23:42                         ` Waskiewicz Jr, Peter P
2008-02-01  4:26                           ` Patrick McHardy
2008-02-01  4:35                           ` Andi Kleen
2008-02-01  4:36                         ` Andi Kleen
2008-01-31 20:33                     ` Jarek Poplawski
2008-01-31 23:04                       ` Jarek Poplawski
2008-02-01  7:42                         ` Jarek Poplawski
2008-02-01  9:28                           ` Waskiewicz Jr, Peter P
2008-02-01 21:47                             ` Jarek Poplawski
2008-02-01  5:01                       ` Andi Kleen
2008-02-01  6:35                     ` Glen Turner
2008-02-01  6:46                       ` Patrick McHardy
2008-02-01  7:46                       ` Andi Kleen
2008-02-01  7:25                         ` Patrick McHardy
2008-02-01  9:37                           ` Waskiewicz Jr, Peter P
2008-02-01  9:56                             ` Patrick McHardy
2008-02-01 12:06                               ` jamal
2008-02-01 19:02                                 ` Waskiewicz Jr, Peter P
2008-02-01 22:56                                 ` Jarek Poplawski
2008-02-02  1:51                                   ` Waskiewicz Jr, Peter P
2008-02-02  5:20                                 ` Andi Kleen
2008-02-01 14:34                             ` Andi Kleen
2008-02-01 17:24                               ` Stephen Hemminger
2008-01-31 18:48                 ` Patrick McHardy
2008-02-02 22:57             ` Herbert Xu
2008-02-03  9:35               ` Andi Kleen
2008-01-31 18:26 ` Rick Jones
2008-01-31 19:03   ` Andi Kleen
2008-01-31 18:35     ` Rick Jones
2008-01-31 19:25       ` Andi Kleen
2008-01-31 19:14         ` Rick Jones
2008-02-01  1:04           ` Andy Furniss
2008-02-01  4:31           ` Andi Kleen
2008-02-02 22:59             ` Herbert Xu
2008-02-01 21:58     ` Rick Jones
2008-02-02  4:10       ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080202041005.GB12644@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rick.jones2@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).