From: David Miller <davem@davemloft.net>
To: johfel@gmx.de
Cc: netdev@vger.kernel.org, den@openvz.org
Subject: Re: [PATCH] [IPV4]: Fix compiler error with CONFIG_PROC_FS=n
Date: Tue, 05 Feb 2008 16:34:22 -0800 (PST) [thread overview]
Message-ID: <20080205.163422.122562967.davem@davemloft.net> (raw)
In-Reply-To: <1202237034.9289.8.camel@localhost>
From: Johann Felix Soden <johfel@gmx.de>
Date: Tue, 05 Feb 2008 19:43:54 +0100
> From: Johann Felix Soden <johfel@users.sourceforge.net>
>
> Handle CONFIG_PROC_FS=n in net/ipv4/fib_frontend.c because:
>
> net/ipv4/fib_frontend.c: In function 'fib_net_init':
> net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_init'
> net/ipv4/fib_frontend.c: In function 'fib_net_exit':
> net/ipv4/fib_frontend.c:1047: error: implicit declaration of function 'fib_proc_exit'
>
> Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
I'm pretty sure I merged in a change this morning which fixes
this.
BTW, in general we do not put ifdefs into *.c code to fix stuff
like this, instead we add empty implementations into a header
file which is a better place for ifdef tests.
And that's how the patch which was merged handles this problem.
prev parent reply other threads:[~2008-02-06 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 18:43 [PATCH] [IPV4]: Fix compiler error with CONFIG_PROC_FS=n Johann Felix Soden
2008-02-05 19:57 ` Denis V. Lunev
2008-02-06 0:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080205.163422.122562967.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=den@openvz.org \
--cc=johfel@gmx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).