From: Stephen Hemminger <shemminger@vyatta.com>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] vlan tag match
Date: Tue, 5 Feb 2008 08:21:50 -0800 [thread overview]
Message-ID: <20080205082150.02e610b1@extreme> (raw)
In-Reply-To: <47A871FF.5000406@trash.net>
On Tue, 05 Feb 2008 15:26:07 +0100
Patrick McHardy <kaber@trash.net> wrote:
> David Miller wrote:
> > From: Stephen Hemminger <shemminger@vyatta.com>
> > Date: Thu, 31 Jan 2008 21:50:25 -0800
> >
> >> On Fri, 01 Feb 2008 06:34:34 +0100
> >> Patrick McHardy <kaber@trash.net> wrote:
> >>
> >>> Stephen Hemminger wrote:
> >>>> Provide a way to use tc filters on vlan tag even if tag is buried in
> >>>> skb due to hardware acceleration.
> >>> Looks reasonable. Would you like to add the same feature to the
> >>> flow classifier?
> >> Yes, that would be good.
> >
> > Did that patch get posted? I didn't see it.
>
>
> No, but I already added it myself. I'll post it in a new thread.
>
> BTW, Stephen, I noticed your ematch patch doesn't mask out the
> VLAN priority which is also included in the return value of
> vlan_get_tag(), is that intentional?
>
It seemed easier than adding two different tag related matches,
since meta match can do expressions.
--
Stephen Hemminger <stephen.hemminger@vyatta.com>
next prev parent reply other threads:[~2008-02-05 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 3:46 "no new features" David Miller
2008-02-01 5:07 ` [PATCH] vlan tag match Stephen Hemminger
2008-02-01 5:34 ` Patrick McHardy
2008-02-01 5:50 ` Stephen Hemminger
2008-02-05 11:20 ` David Miller
2008-02-05 14:26 ` Patrick McHardy
2008-02-05 16:21 ` Stephen Hemminger [this message]
2008-02-05 11:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080205082150.02e610b1@extreme \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).