netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dlezcano@fr.ibm.com
Cc: netdev@vger.kernel.org
Subject: Re: [patch 00/14] replace __inline__ by inline in net code
Date: Wed, 06 Feb 2008 03:29:29 -0800 (PST)	[thread overview]
Message-ID: <20080206.032929.129642913.davem@davemloft.net> (raw)
In-Reply-To: <20080206091405.581849582@mai.toulouse-stg.fr.ibm.com>

From: Daniel Lezcano <dlezcano@fr.ibm.com>
Date: Wed, 06 Feb 2008 10:14:05 +0100

> The following patchset replaces all occurences of __inline__
> by inline and make some minor coding style fixes.
> 
> It touches:
>   . net/* files
>   . include/net/* files
>   . include/linux/* files (only the ones related to the network)
> 
> The patchset touches a lot of files and that can probably increase
> the patch conflict probability, but I have this patchset since a 
> few days, I didn't noticed any problem when updating net-2.6 and I
> hope that will be still the case.
> IMHO, it is the right moment to send this patch out, since net-2.6.25
> is closed and net-2.6.26 is not yet opened.

You have a point, but you also don't.

This makes debugging much harder since they not only have to go
through the real changes, they also have to go through transformations
like this one.

I'd much rather queue this up into net-2.6.26 when I open that up and
deal with whatever rejects.  For trivial transformations like this I
can resolve the rejects with my eyes closed. :-)


      parent reply	other threads:[~2008-02-06 11:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06  9:14 [patch 00/14] replace __inline__ by inline in net code Daniel Lezcano
2008-02-06  9:14 ` [patch 01/14] replace __inline__ by inline in net/ipv4 Daniel Lezcano
2008-02-06  9:14 ` [patch 02/14] replace __inline__ by inline in net/ipv6 Daniel Lezcano
2008-02-06  9:14 ` [patch 03/14] replace __inline__ by inline in net/appletalk Daniel Lezcano
2008-02-06  9:14 ` [patch 04/14] replace __inline__ by inline in net/atm Daniel Lezcano
2008-02-06  9:14 ` [patch 05/14] replace __inline__ by inline in net/core Daniel Lezcano
2008-02-06  9:14 ` [patch 06/14] replace __inline__ by inline in net/decnet Daniel Lezcano
2008-02-06  9:14 ` [patch 07/14] replace __inline__ by inline in net/sched Daniel Lezcano
2008-02-06  9:14 ` [patch 08/14] replace __inline__ by inline in net/x25 Daniel Lezcano
2008-02-06  9:14 ` [patch 09/14] replace __inline__ by inline in net/llc Daniel Lezcano
2008-02-06  9:14 ` [patch 10/14] replace __inline__ by inline in net/lapb Daniel Lezcano
2008-02-06  9:14 ` [patch 11/14] replace __inline__ by inline in net/key Daniel Lezcano
2008-02-06  9:14 ` [patch 12/14] replace __inline__ by inline in net/ipx Daniel Lezcano
2008-02-06  9:14 ` [patch 13/14] replace __inline__ by inline in include/net Daniel Lezcano
2008-02-06  9:14 ` [patch 14/14] replace __inline__ by inline in include/linux (net related) Daniel Lezcano
2008-02-06 10:31   ` YOSHIFUJI Hideaki / 吉藤英明
2008-02-06 10:39     ` Daniel Lezcano
2008-02-06 11:27       ` David Miller
2008-02-06 12:13         ` Daniel Lezcano
2008-02-06 11:25     ` David Miller
2008-02-06 11:29 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206.032929.129642913.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dlezcano@fr.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).