From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netfilter-devel@vger.kernel.org, den@openvz.org, netdev@vger.kernel.org
Subject: Re: [IPV4]: route: fix crash ip_route_input
Date: Thu, 07 Feb 2008 17:58:37 -0800 (PST) [thread overview]
Message-ID: <20080207.175837.202612782.davem@davemloft.net> (raw)
In-Reply-To: <47A9B7F9.3090808@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Wed, 06 Feb 2008 14:36:57 +0100
> [IPV4]: route: fix crash ip_route_input
>
> ip_route_me_harder() may call ip_route_input() with skbs that don't
> have skb->dev set for skbs rerouted in LOCAL_OUT and TCP resets
> generated by the REJECT target, resulting in a crash when dereferencing
> skb->dev->nd_net. Since ip_route_input() has an input device argument,
> it seems correct to use that one anyway.
>
> Bug introduced in b5921910a1 (Routing cache virtualization).
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied, thanks Patrick.
prev parent reply other threads:[~2008-02-08 1:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 13:36 [IPV4]: route: fix crash ip_route_input Patrick McHardy
2008-02-08 1:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207.175837.202612782.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=den@openvz.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).