From: Christoph Hellwig <hch@infradead.org>
To: Ursula Braun <braunu@de.ibm.com>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, Peter Tiedemann <ptiedem@de.ibm.com>
Subject: Re: [patch 1/4] ctc / netiucv: consolidate fsm_action_nop
Date: Thu, 7 Feb 2008 01:26:21 -0500 [thread overview]
Message-ID: <20080207062621.GA27498@infradead.org> (raw)
In-Reply-To: <20080206183021.700790000@linux.vnet.ibm.com>
On Wed, Feb 06, 2008 at 07:27:24PM +0100, Ursula Braun wrote:
> +/**
> + * NOP action for statemachines
> + */
> +static inline void
> +fsm_action_nop(fsm_instance *fi, int event, void *arg)
> +{
> +}
This is put into a method table, which means taking the address of it.
So marking this inline doesn't make much sense, it should be out of
line somewhere in common code.
> static struct device_driver netiucv_driver = {
> + .owner = THIS_MODULE,
> .name = "netiucv",
> .bus = &iucv_bus,
This is uncodumented in the changelog and completely unrelated
to the other change in here.
next prev parent reply other threads:[~2008-02-07 6:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 18:27 [patch 0/4] s390: ctc patches for 2.6.25 (3rd try) Ursula Braun
2008-02-06 18:27 ` [patch 1/4] ctc / netiucv: consolidate fsm_action_nop Ursula Braun
2008-02-07 6:26 ` Christoph Hellwig [this message]
2008-02-06 18:27 ` [patch 2/4] drivers/s390/net: Kconfig brush up Ursula Braun
2008-02-06 18:27 ` [patch 3/4] ctcm: infrastructure for replaced ctc driver Ursula Braun
2008-02-07 6:35 ` Christoph Hellwig
2008-02-07 11:52 ` Rick Troth
2008-02-06 18:27 ` [patch 4/4] ctc: removal of the old " Ursula Braun
-- strict thread matches above, loose matches on Subject: below --
2008-02-06 11:55 [patch 0/4] s390: ctc patches for 2.6.25 (2nd try) Ursula Braun
2008-02-06 11:55 ` [patch 1/4] ctc / netiucv: consolidate fsm_action_nop Ursula Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080207062621.GA27498@infradead.org \
--to=hch@infradead.org \
--cc=braunu@de.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ptiedem@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).