From: Andrew Morton <akpm@linux-foundation.org>
To: David Dillow <dave@thedillows.org>
Cc: davem@davemloft.net, jeff@garzik.org, netdev@vger.kernel.org,
sam@ravnborg.org
Subject: Re: [patch 1/7] typhoon section fix
Date: Fri, 8 Feb 2008 09:52:33 -0800 [thread overview]
Message-ID: <20080208095233.722d7c47.akpm@linux-foundation.org> (raw)
In-Reply-To: <1202479150.4349.0.camel@obelisk.thedillows.org>
On Fri, 08 Feb 2008 08:59:10 -0500 David Dillow <dave@thedillows.org> wrote:
>
> On Fri, 2008-02-08 at 03:11 -0800, akpm@linux-foundation.org wrote:
> > From: Andrew Morton <akpm@linux-foundation.org>
> >
> > gcc-3.4.4 on powerpc:
> >
> > drivers/net/typhoon.c:137: error: version causes a section type conflict
> >
> > Cc: Jeff Garzik <jeff@garzik.org>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> > -static const char version[] __devinitdata =
> > +static char version[] __devinitdata =
> > "typhoon.c: version " DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n";
>
> Wouldn't going to __devinitconst be better? I'll try to whip up a patch
> and test-compile it.
Sam told me that doesn't work right, that this approach is the one to use
and, iirc, that __devinitcont and friends will be removed.
I'm not sure why, actually. I think I missed that dicussion.
next prev parent reply other threads:[~2008-02-08 17:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 11:11 [patch 1/7] typhoon section fix akpm
2008-02-08 13:59 ` David Dillow
2008-02-08 17:52 ` Andrew Morton [this message]
2008-02-08 18:21 ` David Dillow
2008-02-08 19:03 ` Sam Ravnborg
2008-02-11 8:22 ` Jan Beulich
2008-02-10 7:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080208095233.722d7c47.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave@thedillows.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).