From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] libertas: Don't mark exported symbols as static Date: Fri, 8 Feb 2008 23:48:58 -0500 Message-ID: <20080209044858.GA1428@infradead.org> References: <20080208162824.461451e1@extreme> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stephen Hemminger , netdev@vger.kernel.org To: Roland Dreier Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:54690 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbYBIEt1 (ORCPT ); Fri, 8 Feb 2008 23:49:27 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Feb 08, 2008 at 06:01:02PM -0800, Roland Dreier wrote: > > Why not pull the exports? they aren't used anywhere in the existing kernel. > > I'm guessing there's some not-(yet-)merged mesh networking stuff that > uses the symbols, but it doesn't matter much to me... The general rule is to not keep symbols for out of tree stuff, so removing the exports makes more sense.