From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] fib_trie: rcu_assign_pointer warning fix Date: Mon, 11 Feb 2008 21:15:08 -0800 (PST) Message-ID: <20080211.211508.186572349.davem@davemloft.net> References: <20080211165954.2f1b3a9b@extreme> <20080212012741.GD29254@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: shemminger@vyatta.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: paulmck@linux.vnet.ibm.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:39591 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752030AbYBLFOg (ORCPT ); Tue, 12 Feb 2008 00:14:36 -0500 In-Reply-To: <20080212012741.GD29254@linux.vnet.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: From: "Paul E. McKenney" Date: Mon, 11 Feb 2008 17:27:41 -0800 > On Mon, Feb 11, 2008 at 04:59:54PM -0800, Stephen Hemminger wrote: > > Eliminate warnings when rcu_assign_pointer is used with unsigned long. > > It is reasonable to use RCU with non-pointer values so allow it for general > > use. Add a comment to explain the if test. > > Good catch!!! (An apologies for the hassle!!!) > > Acked-by: Paul E. McKenney Thanks for reviewing Paul, I'll apply this.