From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH][AX25] Fwd: SMP with AX.25 Date: Mon, 11 Feb 2008 21:37:18 -0800 (PST) Message-ID: <20080211.213718.210575246.davem@davemloft.net> References: <20080206074529.GC4496@ff.dom.local> <20080206081509.GD4496@ff.dom.local> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, ralf@linux-mips.org, jann@gmx.de To: jarkao2@gmail.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:37541 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752083AbYBLFgq (ORCPT ); Tue, 12 Feb 2008 00:36:46 -0500 In-Reply-To: <20080206081509.GD4496@ff.dom.local> Sender: netdev-owner@vger.kernel.org List-ID: From: Jarek Poplawski Date: Wed, 6 Feb 2008 08:15:09 +0000 > On Wed, Feb 06, 2008 at 07:45:29AM +0000, Jarek Poplawski wrote: > ... > > From: Jann Traschewski > > Subject: SMP with AX.25 > > > [AX25] ax25_timer: use mod_timer instead of add_timer > > According to one of Jann's OOPS reports it looks like > BUG_ON(timer_pending(timer)) triggers during add_timer() > in ax25_start_t1timer(). This patch changes current use > of: init_timer(), add_timer() and del_timer() to > setup_timer() with mod_timer(), which should be safer > anyway. > > > Reported-by: Jann Traschewski > Signed-off-by: Jarek Poplawski Applied.