netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] Execute tasklets in the same order they were queued
       [not found] <20080211222813.GA14316@lixom.net>
@ 2008-02-11 22:49 ` Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2008-02-11 22:49 UTC (permalink / raw)
  To: Olof Johansson; +Cc: linux-kernel, netdev

On Mon, 11 Feb 2008 16:28:13 -0600
Olof Johansson <olof@lixom.net> wrote:

> I noticed this when looking at an openswan issue. Openswan (ab?)uses
> the tasklet API to defer processing of packets in some situations,
> with one packet per tasklet_action(). I started noticing sequences of
> reverse-ordered sequence numbers coming over the wire, since new tasklets
> are always queued at the head of the list but processed sequentially.
> 
> Convert it to instead append new entries to the tail of the list. As an
> extra bonus, the splicing code in takeover_tasklets() no longer has to
> iterate over the list.
> 

hm, I'd have thought that this would already have caused problems in
networking.  And perhaps this change might have effects on networking too?

Probably it won't have _much_ effect on networking because networking
probably isn't queueing one tasklet per packet(!) but perhaps with bonded
channels or something like that?


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-11 22:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20080211222813.GA14316@lixom.net>
2008-02-11 22:49 ` [PATCH] Execute tasklets in the same order they were queued Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).