From: Mike Phillips <mikep@linuxtr.net>
To: Adrian Bunk <bunk@kernel.org>
Cc: p2@ace.ulyssis.student.kuleuven.ac.be, jgarzik@pobox.com,
netdev@vger.kernel.org
Subject: Re: [2.6 patch] olympic_open() must be __devinit
Date: Mon, 11 Feb 2008 14:03:35 -0500 [thread overview]
Message-ID: <20080211190335.GA4304@linuxtr.net> (raw)
In-Reply-To: <20080130200207.GJ29368@does.not.exist>
On Wed, Jan 30, 2008 at 10:02:07PM +0200, Adrian Bunk wrote:
> This patch fixes the following section mismatch:
>
> <-- snip -->
>
> ...
> WARNING: drivers/net/built-in.o(.text+0x155573): Section mismatch in reference from the function olympic_open() to the function .devinit.text:olympic_init()
> ...
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> fd1e6e0bb5b17dc85cd24d6263e8751e816f59e6
> diff --git a/drivers/net/tokenring/olympic.c b/drivers/net/tokenring/olympic.c
> index e7b4adc..433c994 100644
> --- a/drivers/net/tokenring/olympic.c
> +++ b/drivers/net/tokenring/olympic.c
> @@ -434,7 +434,7 @@ static int __devinit olympic_init(struct net_device *dev)
>
> }
>
> -static int olympic_open(struct net_device *dev)
> +static int __devinit olympic_open(struct net_device *dev)
> {
> struct olympic_private *olympic_priv=netdev_priv(dev);
> u8 __iomem *olympic_mmio=olympic_priv->olympic_mmio,*init_srb;
>
>
If __devinit marked code is still discarded after initial setup then NACK. open can be called at any time the
interface is ifup'ed. Its most definitely not adapter init code (that's all done in probe).
Mike
prev parent reply other threads:[~2008-02-11 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 20:02 [2.6 patch] olympic_open() must be __devinit Adrian Bunk
2008-02-11 19:03 ` Mike Phillips [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211190335.GA4304@linuxtr.net \
--to=mikep@linuxtr.net \
--cc=bunk@kernel.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=p2@ace.ulyssis.student.kuleuven.ac.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).