* [2.6 patch] olympic_open() must be __devinit
@ 2008-01-30 20:02 Adrian Bunk
2008-02-11 19:03 ` Mike Phillips
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-01-30 20:02 UTC (permalink / raw)
To: p2, mikep, jgarzik; +Cc: netdev
This patch fixes the following section mismatch:
<-- snip -->
...
WARNING: drivers/net/built-in.o(.text+0x155573): Section mismatch in reference from the function olympic_open() to the function .devinit.text:olympic_init()
...
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
fd1e6e0bb5b17dc85cd24d6263e8751e816f59e6
diff --git a/drivers/net/tokenring/olympic.c b/drivers/net/tokenring/olympic.c
index e7b4adc..433c994 100644
--- a/drivers/net/tokenring/olympic.c
+++ b/drivers/net/tokenring/olympic.c
@@ -434,7 +434,7 @@ static int __devinit olympic_init(struct net_device *dev)
}
-static int olympic_open(struct net_device *dev)
+static int __devinit olympic_open(struct net_device *dev)
{
struct olympic_private *olympic_priv=netdev_priv(dev);
u8 __iomem *olympic_mmio=olympic_priv->olympic_mmio,*init_srb;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [2.6 patch] olympic_open() must be __devinit
2008-01-30 20:02 [2.6 patch] olympic_open() must be __devinit Adrian Bunk
@ 2008-02-11 19:03 ` Mike Phillips
0 siblings, 0 replies; 2+ messages in thread
From: Mike Phillips @ 2008-02-11 19:03 UTC (permalink / raw)
To: Adrian Bunk; +Cc: p2, jgarzik, netdev
On Wed, Jan 30, 2008 at 10:02:07PM +0200, Adrian Bunk wrote:
> This patch fixes the following section mismatch:
>
> <-- snip -->
>
> ...
> WARNING: drivers/net/built-in.o(.text+0x155573): Section mismatch in reference from the function olympic_open() to the function .devinit.text:olympic_init()
> ...
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> fd1e6e0bb5b17dc85cd24d6263e8751e816f59e6
> diff --git a/drivers/net/tokenring/olympic.c b/drivers/net/tokenring/olympic.c
> index e7b4adc..433c994 100644
> --- a/drivers/net/tokenring/olympic.c
> +++ b/drivers/net/tokenring/olympic.c
> @@ -434,7 +434,7 @@ static int __devinit olympic_init(struct net_device *dev)
>
> }
>
> -static int olympic_open(struct net_device *dev)
> +static int __devinit olympic_open(struct net_device *dev)
> {
> struct olympic_private *olympic_priv=netdev_priv(dev);
> u8 __iomem *olympic_mmio=olympic_priv->olympic_mmio,*init_srb;
>
>
If __devinit marked code is still discarded after initial setup then NACK. open can be called at any time the
interface is ifup'ed. Its most definitely not adapter init code (that's all done in probe).
Mike
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-11 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-30 20:02 [2.6 patch] olympic_open() must be __devinit Adrian Bunk
2008-02-11 19:03 ` Mike Phillips
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).