From: David Miller <davem@davemloft.net>
To: max@stro.at
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [IRDA] irda_init() nuke useless debug printk
Date: Tue, 12 Feb 2008 18:17:42 -0800 (PST) [thread overview]
Message-ID: <20080212.181742.150703641.davem@davemloft.net> (raw)
In-Reply-To: <1202812247-6878-1-git-send-email-max@stro.at>
From: maximilian attems <max@stro.at>
Date: Tue, 12 Feb 2008 11:30:47 +0100
> irda_init()
> dmesg line is not really informative, thus remove it.
> There are better ways to know that a module is loaded.
>
> Seen on a debian config with IRDA_DEBUG enabled.
>
> Signed-off-by: maximilian attems <max@stro.at>
Well if you look at how IRDA_DEBUG is predominantly used,
it's a function tracer, and that's exactly how it's being
used here.
Either we decide that this is OK and leave it there, or
we start moving the whole IRDA tree over to not do this.
Not something in between.
next prev parent reply other threads:[~2008-02-13 2:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 10:30 [PATCH] [IRDA] irda_init() nuke useless debug printk maximilian attems
2008-02-13 2:17 ` David Miller [this message]
2008-02-13 10:51 ` maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080212.181742.150703641.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=max@stro.at \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).