From: David Miller <davem@davemloft.net>
To: panther@balabit.hu
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] rtnetlink.c: send a single notification on device state changes
Date: Tue, 12 Feb 2008 22:42:52 -0800 (PST) [thread overview]
Message-ID: <20080212.224252.03600088.davem@davemloft.net> (raw)
In-Reply-To: <1202385470416-git-send-email-panther@balabit.hu>
From: Laszlo Attila Toth <panther@balabit.hu>
Date: Thu, 7 Feb 2008 12:57:50 +0100
> In do_setlink() a single notification is sent at the end of the function
> if any modification occured. If the address has been changed, another
> notification is sent.
>
> Both of them is required because originally only the NETDEV_CHANGEADDR
> notification was sent and although device state change implies address
> change, some programs may expect the original notification. It remains
> for compatibity.
>
> If set_operstate() is called from do_setlink(), it doesn't send
> a notification, only if it is called from rtnl_create_link() as earlier.
>
> Signed-off-by: Laszlo Attila Toth <panther@balabit.hu>
Looks good, applied.
Let's hope this doesn't break some stupid application
unintentionally.
next prev parent reply other threads:[~2008-02-13 6:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 16:06 [PATCH 0/2] rtnetlink locking and notification fixes Laszlo Attila Toth
2008-02-01 16:07 ` [PATCH 1/2] Remove unnecessary locks from rtnetlink Laszlo Attila Toth
2008-02-06 1:53 ` David Miller
2008-02-07 11:57 ` [PATCH] rtnetlink.c: send a single notification on device state changes Laszlo Attila Toth
2008-02-13 6:42 ` David Miller [this message]
2008-02-07 12:00 ` [PATCH 1/2] Remove unnecessary locks from rtnetlink Laszlo Attila Toth
2008-02-01 16:07 ` [PATCH 2/2] rtnetlink: send a single notification on device state changes Laszlo Attila Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080212.224252.03600088.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=panther@balabit.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).