From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: viro@ZenIV.linux.org.uk, netdev@vger.kernel.org
Subject: Re: xfrm_input() and ->seq oddities
Date: Tue, 12 Feb 2008 22:54:43 -0800 (PST) [thread overview]
Message-ID: <20080212.225443.86986730.davem@davemloft.net> (raw)
In-Reply-To: <20080203220027.GA11641@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 4 Feb 2008 09:00:27 +1100
> On Sun, Feb 03, 2008 at 11:04:44AM +0000, Al Viro wrote:
> > IMO that at least deserves a comment near xfrm_input()...
>
> Sure. There is already a comment about encap_type < 0 in there, but
> I think you'll probably be able to explain it much better than I can
> looking in from the outside so if you have a patch... :)
Agreed on all counts ;-)
next prev parent reply other threads:[~2008-02-13 6:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 21:16 [2.6 patch] xfrm4_beet_input(): fix an if() Adrian Bunk
2008-02-02 22:22 ` Herbert Xu
[not found] ` <20080202235827.GP27894@ZenIV.linux.org.uk>
2008-02-03 0:20 ` xfrm_input() and ->seq oddities Herbert Xu
2008-02-03 0:37 ` Al Viro
2008-02-03 3:05 ` Herbert Xu
2008-02-03 11:04 ` Al Viro
2008-02-03 22:00 ` Herbert Xu
2008-02-13 6:54 ` David Miller [this message]
2008-02-13 6:54 ` David Miller
2008-02-05 10:51 ` [2.6 patch] xfrm4_beet_input(): fix an if() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080212.225443.86986730.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).