From: maximilian attems <max@stro.at>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Samuel Ortiz <samuel@sortiz.org>
Subject: Re: [PATCH] [IRDA] irda_init() nuke useless debug printk
Date: Wed, 13 Feb 2008 11:51:58 +0100 [thread overview]
Message-ID: <20080213105158.GA15544@stro.at> (raw)
In-Reply-To: <20080212.181742.150703641.davem@davemloft.net>
On Tue, 12 Feb 2008, David Miller wrote:
> From: maximilian attems <max@stro.at>
> Date: Tue, 12 Feb 2008 11:30:47 +0100
>
> > irda_init()
> > dmesg line is not really informative, thus remove it.
> > There are better ways to know that a module is loaded.
> >
> > Seen on a debian config with IRDA_DEBUG enabled.
> >
> > Signed-off-by: maximilian attems <max@stro.at>
>
> Well if you look at how IRDA_DEBUG is predominantly used,
> it's a function tracer, and that's exactly how it's being
> used here.
>
> Either we decide that this is OK and leave it there, or
> we start moving the whole IRDA tree over to not do this.
> Not something in between.
ack, happy with both.
i could also lower the visibility of that one.
it simply struck out on my sfuzz test runs, had this
dmesg line instead of usual stuff:
-- snipp
NET: Registered protocol family 9
X.25 for Linux Version 0.2
Bridge firewalling registered
PPP generic driver version 2.4.2
NET: Registered protocol family 24
Sangoma WANPIPE Router v1.1 (c) 1995-2000 Sangoma Technologies Inc.
NET: Registered protocol family 4
NET4: DECnet for Linux: V.2.5.68s (C) 1995-2003 Linux DECnet Project Team
DECnet: Routing cache hash table of 1024 buckets, 16Kbytes
NET: Registered protocol family 12
Bluetooth: Core ver 2.11
NET: Registered protocol family 31
Bluetooth: HCI device and connection manager initialized
Bluetooth: HCI socket layer initialized
NET: Registered protocol family 15
NET: Registered protocol family 5
irda_init()
NET: Registered protocol family 23
--
prev parent reply other threads:[~2008-02-13 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 10:30 [PATCH] [IRDA] irda_init() nuke useless debug printk maximilian attems
2008-02-13 2:17 ` David Miller
2008-02-13 10:51 ` maximilian attems [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213105158.GA15544@stro.at \
--to=max@stro.at \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).