From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: jann@gmx.de, f6bvp@free.fr, ralf@linux-mips.org, netdev@vger.kernel.org
Subject: Re: [PATCH][AX25] ax25_out: check skb for NULL in ax25_kick()
Date: Sun, 17 Feb 2008 22:31:40 -0800 (PST) [thread overview]
Message-ID: <20080217.223140.193122711.davem@davemloft.net> (raw)
In-Reply-To: <20080213115607.GB2867@ff.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Wed, 13 Feb 2008 11:56:07 +0000
> [AX25] ax25_out: check skb for NULL in ax25_kick()
>
> According to some OOPS reports ax25_kick tries to clone NULL skbs
> sometimes. It looks like a race with ax25_clear_queues(). Probably
> there is no need to add more than a simple check for this yet.
> Another report suggested there are probably also cases where ax25
> ->paclen == 0 can happen in ax25_output(); this wasn't confirmed
> during testing but let's leave this debugging check for some time.
>
> Reported-and-tested-by: Jann Traschewski <jann@gmx.de>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Applied, thanks Jarek.
prev parent reply other threads:[~2008-02-18 6:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00f201c8694a$2770f630$453c822c@dg8ngn>
[not found] ` <cd9157050802071100m76a742bbyb18f4448d8ec436b@mail.gmail.com>
2008-02-06 7:45 ` [BUG][AX25] Fwd: SMP with AX.25 Jarek Poplawski
2008-02-06 8:15 ` [PATCH][AX25] " Jarek Poplawski
2008-02-06 9:14 ` [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer Jarek Poplawski
2008-02-10 18:23 ` Jann Traschewski
2008-02-12 5:38 ` David Miller
2008-02-12 5:37 ` [PATCH][AX25] Fwd: SMP with AX.25 David Miller
2008-02-06 9:30 ` [BUG][AX25] " Jarek Poplawski
2008-02-07 12:07 ` Jarek Poplawski
2008-02-07 19:34 ` Jarek Poplawski
2008-02-07 19:35 ` Jarek Poplawski
2008-02-07 20:34 ` Jarek Poplawski
2008-02-13 11:17 ` [PATCH][AX25] mkiss: ax_bump() locking fix Jarek Poplawski
2008-02-15 15:53 ` Jeff Garzik
2008-02-13 11:56 ` [PATCH][AX25] ax25_out: check skb for NULL in ax25_kick() Jarek Poplawski
2008-02-14 0:49 ` Jann Traschewski
2008-03-09 9:02 ` Pidoux
2008-03-09 14:30 ` Jarek Poplawski
2008-03-09 17:34 ` Jann Traschewski
2008-03-09 18:03 ` Jarek Poplawski
2008-03-24 5:03 ` David Miller
2008-02-18 6:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217.223140.193122711.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f6bvp@free.fr \
--cc=jann@gmx.de \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).