From: David Miller <davem@davemloft.net>
To: paul.moore@hp.com
Cc: xemul@openvz.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2][NETLABEL]: Move some initialization code into __init section.
Date: Sun, 17 Feb 2008 22:34:16 -0800 (PST) [thread overview]
Message-ID: <20080217.223416.220789561.davem@davemloft.net> (raw)
In-Reply-To: <200802130837.17249.paul.moore@hp.com>
From: Paul Moore <paul.moore@hp.com>
Date: Wed, 13 Feb 2008 08:37:16 -0500
> On Wednesday 13 February 2008 6:12:06 am Pavel Emelyanov wrote:
> > Everything that is called from netlbl_init() can be marked with
> > __init. This moves 620 bytes from .text section to .text.init one.
> >
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>
> I ran into problems with __init and __exit once because I didn't fully
> understand their impact; this caused me to be rather hesitant to make use of
> them. However, you seem to know what you are doing and these look like
> reasonable changes to me so I'll ack this patch and if we do run into a
> problem the fix should be pretty trivial.
Yes, this stuff can be non-trivial at best on some days :-)
> I appreciate you taking the time to find these optimizations, thanks again.
>
> Acked-by: Paul Moore <paul.moore@hp.com>
Applied.
prev parent reply other threads:[~2008-02-18 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 11:12 [PATCH 2/2][NETLABEL]: Move some initialization code into __init section Pavel Emelyanov
2008-02-13 13:37 ` Paul Moore
2008-02-18 6:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217.223416.220789561.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).