From: David Miller <davem@davemloft.net>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-kernel@vger.kernel.org, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.24 1/1] sch_htb: fix "too many events" situation
Date: Sun, 17 Feb 2008 23:28:29 -0800 (PST) [thread overview]
Message-ID: <20080217.232829.222344360.davem@davemloft.net> (raw)
In-Reply-To: <E1JPn6W-0002J2-5x@luxik.cdi.cz>
From: Martin Devera <devik@cdi.cz>
Date: Fri, 15 Feb 2008 00:02:56 +0100
> From: Martin Devera <devik@cdi.cz>
>
> HTB is event driven algorithm and part of its work is to apply
> scheduled events at proper times. It tried to defend itself from
> livelock by processing only limited number of events per dequeue.
> Because of faster computers some users already hit this hardcoded
> limit.
> This patch uses loops_per_jiffy variable to limit event processing
> up to single jiffy interval and then delay remainder to other
> jiffy.
>
> Signed-off-by: Martin Devera <devik@cdi.cz>
I think we would be wise to use something other than loops_per_jiffy.
Depending upon the loop calibration method used by a particular
architecture it can me one of many different things.
Some platforms don't even make use of it and thus leave it at it's
default value of "1<<12", so using it as a heuristic here is arbitrary
at best.
next prev parent reply other threads:[~2008-02-18 7:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 23:02 [PATCH 2.6.24 1/1] sch_htb: fix "too many events" situation Martin Devera
2008-02-18 7:28 ` David Miller [this message]
2008-02-18 8:03 ` Martin Devera
2008-02-18 8:17 ` David Miller
2008-02-18 10:08 ` Martin Devera
2008-02-18 10:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217.232829.222344360.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).