netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ggriffin.kernel@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Support arbitrary initial TCP timestamps
Date: Sun, 17 Feb 2008 23:33:30 -0800 (PST)	[thread overview]
Message-ID: <20080217.233330.157255657.davem@davemloft.net> (raw)
In-Reply-To: <1203097630-13237-1-git-send-email-ggriffin.kernel@gmail.com>

From: Glenn Griffin <ggriffin.kernel@gmail.com>
Date: Fri, 15 Feb 2008 09:47:08 -0800

> Introduce the ability to send arbitrary initial tcp timestamps that are not
> tied directly to jiffies.  The basic conecpt is every tcp_request_sock and
> tcp_sock now has a ts_off offset that represents the difference between
> tcp_time_stamp and the timestamp we send and expect to
> receive.
> 
> This has the advantage of not divulging system information (uptime)
> depending on the policy chosen for the initial timestamps.
> 
> A policy where ts_off is always set to zero should produce no change in
> behavior.  The policy implemented is not intended for real use, but just as
> a simple example.  A realistic example would probably be similar to the tcp
> init sequence generator.
> 
> Signed-off-by: Glenn Griffin <ggriffin.kernel@gmail.com>

Adding yet another member to the already bloated tcp_sock structure to
implement this is too high a cost.

I would instead prefer that there be some global random number
calculated when the first TCP socket is created, and use that as a
global offset.  You can even recompute it every few hours if you
like.

We do similar things already elsewhere.

  parent reply	other threads:[~2008-02-18  7:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15 17:47 [PATCH 1/3] Support arbitrary initial TCP timestamps Glenn Griffin
2008-02-15 17:47 ` [PATCH 2/3] Enable the use of TCP options with syncookies Glenn Griffin
2008-02-15 17:47   ` [PATCH 3/3] Add IPv6 Support to TCP SYN cookies Glenn Griffin
2008-02-18  7:33 ` David Miller [this message]
2008-02-18 22:46   ` [PATCH 1/3] Support arbitrary initial TCP timestamps Glenn Griffin
2008-02-19 18:02     ` Glenn Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080217.233330.157255657.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ggriffin.kernel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).