Re: [PATCH][PPPOL2TP] add missing sock_put() in pppol2tp_recv_dequeue()

James Chapman
2008-03-02T20:31:20Z

Jarek Poplawski wrote:

> Subject: [PPPOL2TP] add missing sock_put() in pppol2tp_recv_dequeue()
>
> Every skb removed from session->reorder_q needs sock_put().
>
>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Acked-by: James Chapman <jchapman@katalix.com>

>
> ---
>
> drivers/net/pppol2tp.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c
> index e0b072d..dcd4991 100644
> --- a/drivers/net/pppol2tp.c
> +++ b/drivers/net/pppol2tp.c
> @@ -455,6 +455,7 @@ static void pppol2tp_recv_dequeue(struct pppol2tp_session *session)
> skb_queue_len(&session->reorder_q));
> __skb_unlink(skb, &session->reorder_q);
> kfree_skb(skb);
> + sock_put(session->sock);
> continue;
> }
>

--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development