From: Stephen Hemminger <shemminger@vyatta.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: bonding-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: simplify code and get rid of warning
Date: Wed, 20 Feb 2008 09:24:30 -0800 [thread overview]
Message-ID: <20080220092430.623b640f@extreme> (raw)
In-Reply-To: <21522.1203526676@death>
On Wed, 20 Feb 2008 08:57:56 -0800
Jay Vosburgh <fubar@us.ibm.com> wrote:
> Stephen Hemminger <shemminger@vyatta.com> wrote:
>
> >Get rid of warning and simplify code that looks up vlan tag.
> >No need to get tag, then copy it. Also no need for a local status
> >variable.
>
> Granted, the current code is suboptimal, but I don't see any
> warnings compiling this (gcc 4.1.2). What are you getting?
>
Gcc 4.2.3
CC [M] drivers/net/bonding/bond_main.o
drivers/net/bonding/bond_main.c: In function ‘bond_dev_queue_xmit’:
drivers/net/bonding/bond_main.c:386: warning: ‘vlan_id’ may be used uninitialized in this function
CC [M] drivers/net/bonding/bond_3ad.o
CC [M] drivers/net/bonding/bond_alb.o
drivers/net/bonding/bond_alb.c: In function ‘rlb_choose_channel’:
drivers/net/bonding/bond_alb.c:681: warning: ‘vlan_id’ may be used uninitialized in this function
CC [M] drivers/net/bonding/bond_sysfs.o
prev parent reply other threads:[~2008-02-20 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 5:04 [PATCH] bonding: simplify code and get rid of warning Stephen Hemminger
2008-02-20 16:57 ` Jay Vosburgh
2008-02-20 17:24 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220092430.623b640f@extreme \
--to=shemminger@vyatta.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).