From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [RFC PATCH 1/8] [NET]: uninline skb_put, de-bloats a lot Date: Wed, 20 Feb 2008 14:57:32 +0100 Message-ID: <20080220145732.d716355e.dada1@cosmosbay.com> References: <1203515238-22848-1-git-send-email-ilpo.jarvinen@helsinki.fi> <1203515238-22848-2-git-send-email-ilpo.jarvinen@helsinki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Miller , Arnaldo Carvalho de Melo To: =?ISO-8859-1?B?IklscG8gSuRydmluZW4i?= Return-path: Received: from pfx2.jmh.fr ([194.153.89.55]:33303 "EHLO pfx2.jmh.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753764AbYBTN7L convert rfc822-to-8bit (ORCPT ); Wed, 20 Feb 2008 08:59:11 -0500 In-Reply-To: <1203515238-22848-2-git-send-email-ilpo.jarvinen@helsinki.fi> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 20 Feb 2008 15:47:11 +0200 "Ilpo J=E4rvinen" wrote: > ~500 files changed > ... > kernel/uninlined.c: > skb_put | +104 > 1 function changed, 104 bytes added, diff: +104 >=20 > vmlinux.o: > 869 functions changed, 198 bytes added, 111003 bytes removed, diff: = -110805 >=20 > This change is INCOMPLETE, I think that the call to current_text_addr= () > should be rethought but I don't have a clue how to do that. You want to use __builtin_return_address(0) >=20 > Signed-off-by: Ilpo J=E4rvinen > --- > include/linux/skbuff.h | 20 +------------------- > net/core/skbuff.c | 21 +++++++++++++++++++++ > 2 files changed, 22 insertions(+), 19 deletions(-) >=20 > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index 412672a..5925435 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -896,25 +896,7 @@ static inline unsigned char *__skb_put(struct sk= _buff *skb, unsigned int len) > return tmp; > } > =20 > -/** > - * skb_put - add data to a buffer > - * @skb: buffer to use > - * @len: amount of data to add > - * > - * This function extends the used data area of the buffer. If this w= ould > - * exceed the total buffer size the kernel will panic. A pointer to = the > - * first byte of the extra data is returned. > - */ > -static inline unsigned char *skb_put(struct sk_buff *skb, unsigned i= nt len) > -{ > - unsigned char *tmp =3D skb_tail_pointer(skb); > - SKB_LINEAR_ASSERT(skb); > - skb->tail +=3D len; > - skb->len +=3D len; > - if (unlikely(skb->tail > skb->end)) > - skb_over_panic(skb, len, current_text_addr()); > - return tmp; > -} > +extern unsigned char *skb_put(struct sk_buff *skb, unsigned int len)= ; > =20 > static inline unsigned char *__skb_push(struct sk_buff *skb, unsigne= d int len) > { > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index 4e35422..661d439 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -857,6 +857,27 @@ free_skb: > return err; > } > =20 > +/** > + * skb_put - add data to a buffer > + * @skb: buffer to use > + * @len: amount of data to add > + * > + * This function extends the used data area of the buffer. If this w= ould > + * exceed the total buffer size the kernel will panic. A pointer to = the > + * first byte of the extra data is returned. > + */ > +unsigned char *skb_put(struct sk_buff *skb, unsigned int len) > +{ > + unsigned char *tmp =3D skb_tail_pointer(skb); > + SKB_LINEAR_ASSERT(skb); > + skb->tail +=3D len; > + skb->len +=3D len; > + if (unlikely(skb->tail > skb->end)) > + skb_over_panic(skb, len, current_text_addr()); > + return tmp; > +} > +EXPORT_SYMBOL(skb_put); > + > /* Trims skb to length len. It can change skb pointers. > */ > =20 > --=20 > 1.5.2.2 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >=20