From: Phil Oester <kernel@linuxace.com>
To: netdev@vger.kernel.org
Cc: kaber@trash.net
Subject: [PATCH] Fix multicast on VLAN interfaces
Date: Thu, 21 Feb 2008 14:05:42 -0800 [thread overview]
Message-ID: <20080221220542.GA19693@linuxace.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
In commit 56addd6eeeb4e11f5a0af7093ca078e0f29140e0 the VLAN multicast list
handling was reworked. Unfortunately, a variable initialization was missed,
and multicast over vlan devices has been broken since 2.6.23-rc1 (apparently
not too many people use this). Trivial fix below, which might be a candidate
for -stable.
Phil
Signed-off-by: Phil Oester <kernel@linuxace.com>
[-- Attachment #2: patch-mcast-vlan --]
[-- Type: text/plain, Size: 371 bytes --]
diff --git a/net/core/dev.c b/net/core/dev.c
index 908f07c..999af2e 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2905,6 +2905,7 @@ int __dev_addr_add(struct dev_addr_list **list, int *count,
return -ENOMEM;
memcpy(da->da_addr, addr, alen);
da->da_addrlen = alen;
+ da->da_synced = 0;
da->da_users = 1;
da->da_gusers = glbl ? 1 : 0;
da->next = *list;
next reply other threads:[~2008-02-21 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 22:05 Phil Oester [this message]
2008-02-22 12:25 ` [PATCH] Fix multicast on VLAN interfaces Patrick McHardy
2008-02-24 4:00 ` David Miller
2008-02-24 6:32 ` Phil Oester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080221220542.GA19693@linuxace.com \
--to=kernel@linuxace.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).