From: Thomas Graf <tgraf@suug.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [RTNL]: Validate hardware and broadcast address attribute for RTM_NEWLINK
Date: Fri, 22 Feb 2008 14:31:35 +0100 [thread overview]
Message-ID: <20080222133135.GC20815@postel.suug.ch> (raw)
In-Reply-To: <47BEC89E.9030909@trash.net>
* Patrick McHardy <kaber@trash.net> 2008-02-22 14:05
> Minor nitpick: it would be more logical to put this in the
>
> if (dev) {
> ...
>
> branch a bit below since thats the only path that leads to
> do_setlink(). That would also allow to remove the
> if (dev) check from validate_linkmsg().
I knew this question would come up :-)
The reason I did it this way is to keep validate_linkmsg() generic
and make it possible to put validation code which must also apply
to new links (dev==NULL) into that function.
next prev parent reply other threads:[~2008-02-22 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 12:57 [RTNL]: Validate hardware and broadcast address attribute for RTM_NEWLINK Thomas Graf
2008-02-22 13:05 ` Patrick McHardy
2008-02-22 13:31 ` Thomas Graf [this message]
2008-02-22 13:33 ` Patrick McHardy
2008-02-24 3:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080222133135.GC20815@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).