[PATCH 03/08] [TIPC]: Eliminate "sparse" warning in socket code

[PATCH 03/08] [TIPC]: Eliminate "sparse" warning in socket code

[Stephens, Allan]

This patch eliminates warnings about a pair of undeclared symbols.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
---
 net/tipc/socket.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index e5a6983..356a18c 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -81,6 +81,12 @@ static int sockets_enabled = 0;
 
 static atomic_t tipc_queue_size = ATOMIC_INIT(0);
 
+/*
+ * Declare public routines so "sparse" doesn't complain ...
+ */
+
+extern int  tipc_socket_init(void);
+extern void tipc_socket_stop(void);
 
 /*
  * sock_lock(): Lock a port/socket pair. lock_sock() can
-- 
1.5.3.2

Re: [PATCH 03/08] [TIPC]: Eliminate "sparse" warning in socket code

[Sam Ravnborg]

On Fri, Feb 22, 2008 at 11:59:12AM -0800, Stephens, Allan wrote:
> This patch eliminates warnings about a pair of undeclared symbols.

Hi Allan.

Last I looked there where ~90 sparse warnings for tipc.
I assume you are aware and that they are getting fixed.

	Sam - who would like to see an almost sparse clean kernel

RE: [PATCH 03/08] [TIPC]: Eliminate "sparse" warning in socket code

[Stephens, Allan]

Hi Sam:

Yes and yes.  Some fixes will occur naturally as the problematic code
has already been rewritten in TIPC 1.7, but other fixes will need to be
developed.  I'll see what I can do to accelerate the process ...

-- Al 

-----Original Message-----
From: Sam Ravnborg [mailto:sam@ravnborg.org] 
Sent: Friday, February 22, 2008 3:04 PM
To: Stephens, Allan
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 03/08] [TIPC]: Eliminate "sparse" warning in socket
code

On Fri, Feb 22, 2008 at 11:59:12AM -0800, Stephens, Allan wrote:
> This patch eliminates warnings about a pair of undeclared symbols.

Hi Allan.

Last I looked there where ~90 sparse warnings for tipc.
I assume you are aware and that they are getting fixed.

	Sam - who would like to see an almost sparse clean kernel