netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jwestfall@surrealistic.net
Cc: netdev@vger.kernel.org, acme@ghostprotocols.net
Subject: Re: kernel BUG at net/core/skbuff.c:95!
Date: Sat, 23 Feb 2008 20:01:30 -0800 (PST)	[thread overview]
Message-ID: <20080223.200130.119882236.davem@davemloft.net> (raw)
In-Reply-To: <20080221191352.GV84358@surrealistic.net>

From: Jim Westfall <jwestfall@surrealistic.net>
Date: Thu, 21 Feb 2008 11:13:52 -0800

> > 
> > 2) Second, skb_realloc_headroom() is called on 'skb' with
> >    a second argument of 'dsize'.
> 
> This suggestion escapes me.  The skb_put() call in the above 
> code would increase skb->tail.  Wont skb_realloc_headroom() create 
> additional space between skb->head and skb->data when we really want it 
> between skb->tail and skb->end?

My bad, you need to increase the tailroom not the headroom.

      reply	other threads:[~2008-02-24  4:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20  0:20 kernel BUG at net/core/skbuff.c:95! Jim Westfall
2008-02-21  5:46 ` Jim Westfall
2008-02-21  5:57   ` David Miller
2008-02-21 19:13     ` Jim Westfall
2008-02-24  4:01       ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080223.200130.119882236.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=acme@ghostprotocols.net \
    --cc=jwestfall@surrealistic.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).