From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 8/8] Jhash in too big for inlining, move under lib/
Date: Sat, 23 Feb 2008 10:21:59 -0800
Message-ID: <20080223102159.74a465cb.akpm@linux-foundation.org>
References: <1203515238-22848-1-git-send-email-ilpo.jarvinen@helsinki.fi>
	<1203515238-22848-2-git-send-email-ilpo.jarvinen@helsinki.fi>
	<1203515238-22848-3-git-send-email-ilpo.jarvinen@helsinki.fi>
	<1203515238-22848-4-git-send-email-ilpo.jarvinen@helsinki.fi>
	<1203515238-22848-5-git-send-email-ilpo.jarvinen@helsinki.fi>
	<1203515238-22848-6-git-send-email-ilpo.jarvinen@helsinki.fi>
	<1203515238-22848-7-git-send-email-ilpo.jarvinen@helsinki.fi>
	<1203515238-22848-8-git-send-email-ilpo.jarvinen@helsinki.fi>
	<1203515238-22848-9-git-send-email-ilpo.jarvinen@helsinki.fi>
	<20080223000214.81b1390a.akpm@linux-foundation.org>
	<Pine.LNX.4.64.0802231006360.29504@kivilampi-30.cs.helsinki.fi>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
To: =?ISO-8859-1?B?IklscG8gSuRydmluZW4i?= <ilpo.jarvinen@helsinki.fi>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtp1.linux-foundation.org ([207.189.120.13]:44862 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752709AbYBWSWs convert rfc822-to-8bit
	(ORCPT <rfc822;netdev@vger.kernel.org>);
	Sat, 23 Feb 2008 13:22:48 -0500
In-Reply-To: <Pine.LNX.4.64.0802231006360.29504@kivilampi-30.cs.helsinki.fi>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sat, 23 Feb 2008 12:05:36 +0200 (EET) "Ilpo J=E4rvinen" <ilpo.jarvin=
en@helsinki.fi> wrote:

> On Sat, 23 Feb 2008, Andrew Morton wrote:
>=20
> > On Wed, 20 Feb 2008 15:47:18 +0200 "Ilpo J=E4rvinen" <ilpo.jarvinen=
@helsinki.fi> wrote:
> >=20
> > > vmlinux.o:
> > >  62 functions changed, 66 bytes added, 10935 bytes removed, diff:=
 -10869
> > >=20
> > > ...+ these to lib/jhash.o:
> > >  jhash_3words: 112
> > >  jhash2: 276
> > >  jhash: 475
> > >=20
> > > select for networking code might need a more fine-grained approac=
h.
> >=20
> > It should be possible to use a modular jhash.ko.  The things which =
you
> > have identified as clients of the jhash library are usually loaded =
as modules.
> > But in the case where someone does (say) NFSD=3Dy we do need jhash.=
o linked into
> > vmlinux also. This is doable in Kconfig but I always forget how.
>=20
> Ok, even though its not that likely that one lives without e.g.
> net/ipv4/inet_connection_sock.c or net/netlink/af_netlink.c?

Sure, the number of people who will want CONFIG_JHASH=3Dn is very small=
=2E

> But maybe=20
> some guys "really know what they are doing" and can come up with conf=
ig=20
> that would be able to build it as module (for other than proof-of-con=
cept=20
> uses I mean)... :-/
>=20
> > Adrian, Sam and Randy are the repositories of knowledge here ;)
>=20
> Thanks, I'll consult them in this. I've never needed to do any Kconfi=
g=20
> stuff so far so it's no surprise I have very little clue... :-)

Thanks.  If it gets messy I'd just put lib/jhash.o in obj-y.  I assume =
it's
pretty small.

> I've one question for you Andrew, how would you like this kind of=20
> cross-subsys toucher to be merged, through you directly I suppose?

Sure, I can scrounge around for appropriate reviews and acks and can ma=
ke
sure that nobody's pending work gets disrupted.