[PATCH] [PS3] gelic wireless driver needs MAC80211 support

[PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Sebastian Siewior]

so select it.
Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>
---
 drivers/net/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f337800..a116056 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2363,6 +2363,7 @@ config GELIC_NET
 config GELIC_WIRELESS
        bool "PS3 Wireless support"
        depends on GELIC_NET
+       select MAC80211
        help
         This option adds the support for the wireless feature of PS3.
         If you have the wireless-less model of PS3 or have no plan to
-- 
1.5.3.8

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Ivo van Doorn]

On Saturday 23 February 2008, Sebastian Siewior wrote:
> so select it.
> Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>
> ---
>  drivers/net/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f337800..a116056 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2363,6 +2363,7 @@ config GELIC_NET
>  config GELIC_WIRELESS
>         bool "PS3 Wireless support"
>         depends on GELIC_NET
> +       select MAC80211
>         help
>          This option adds the support for the wireless feature of PS3.
>          If you have the wireless-less model of PS3 or have no plan to

Is there any particular reason why this driver is in drivers/net instead
of drivers/net/wireless (along with all other wireless drivers?

Additionally, all other mac80211 drivers depend on mac80211 instead
of selecting it. So I think for consistency it might be better to also
make this driver depend on it, rather then selecting.

Ivo

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Ivo van Doorn]

On Saturday 23 February 2008, Ivo van Doorn wrote:
> On Saturday 23 February 2008, Sebastian Siewior wrote:
> > so select it.
> > Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>
> > ---
> >  drivers/net/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index f337800..a116056 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -2363,6 +2363,7 @@ config GELIC_NET
> >  config GELIC_WIRELESS
> >         bool "PS3 Wireless support"
> >         depends on GELIC_NET
> > +       select MAC80211
> >         help
> >          This option adds the support for the wireless feature of PS3.
> >          If you have the wireless-less model of PS3 or have no plan to
> 
> Is there any particular reason why this driver is in drivers/net instead
> of drivers/net/wireless (along with all other wireless drivers?
> 
> Additionally, all other mac80211 drivers depend on mac80211 instead
> of selecting it. So I think for consistency it might be better to also
> make this driver depend on it, rather then selecting.

Additionally, what part of the driver actually uses mac80211?
I just browsed to the code, and it seems to work completely without
using mac80211. Instead it seems to work directly by registering a
net_device structure...

Ivo

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Sebastian Siewior]

* Ivo van Doorn | 2008-02-23 20:50:34 [+0100]:

>Additionally, what part of the driver actually uses mac80211?
>I just browsed to the code, and it seems to work completely without
>using mac80211. Instead it seems to work directly by registering a
>net_device structure...
  CC      drivers/net/ps3_gelic_wireless.o
/home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c: In function 'gelic_wl_setup_netdev_ops':
/home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c:2660: error: 'struct net_device' has no member named 'wireless_data'
/home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c:2661: error: 'struct net_device' has no member named 'wireless_handlers'
make[3]: *** [drivers/net/ps3_gelic_wireless.o] Error 1
make[2]: *** [drivers/net] Error 2
make[1]: *** [drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [sub-make] Error 2


I add this to the patch desctiption and post a depends on patach

>Ivo

Sebastian

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Sebastian Siewior]

* Sebastian Siewior | 2008-02-23 21:06:37 [+0100]:

>I add this to the patch desctiption and post a depends on patach
ARGH, this was CONFIG_WIRELESS_EXT and not MAC80211. You would like to
see a select or depend statement on that one?

>>Ivo
>
Sebastian

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Ivo van Doorn]

On Saturday 23 February 2008, Sebastian Siewior wrote:
> * Sebastian Siewior | 2008-02-23 21:06:37 [+0100]:
> 
> >I add this to the patch desctiption and post a depends on patach
> ARGH, this was CONFIG_WIRELESS_EXT and not MAC80211. You would like to
> see a select or depend statement on that one?

Other drivers do a select on WIRELESS_EXT, so selecting it would be fine.

Ivo

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Ivo van Doorn]

On Saturday 23 February 2008, Sebastian Siewior wrote:
> * Ivo van Doorn | 2008-02-23 20:50:34 [+0100]:
> 
> >Additionally, what part of the driver actually uses mac80211?
> >I just browsed to the code, and it seems to work completely without
> >using mac80211. Instead it seems to work directly by registering a
> >net_device structure...
>   CC      drivers/net/ps3_gelic_wireless.o
> /home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c: In function 'gelic_wl_setup_netdev_ops':
> /home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c:2660: error: 'struct net_device' has no member named 'wireless_data'
> /home/bigeasy/git/linux-2.6/drivers/net/ps3_gelic_wireless.c:2661: error: 'struct net_device' has no member named 'wireless_handlers'
> make[3]: *** [drivers/net/ps3_gelic_wireless.o] Error 1
> make[2]: *** [drivers/net] Error 2
> make[1]: *** [drivers] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [sub-make] Error 2
> 
> 
> I add this to the patch desctiption and post a depends on patach

Looking at include/linux/netdevice.h:

#ifdef CONFIG_WIRELESS_EXT
	/* List of functions to handle Wireless Extensions (instead of ioctl).
	 * See <net/iw_handler.h> for details. Jean II */
	const struct iw_handler_def *	wireless_handlers;
	/* Instance data managed by the core of Wireless Extensions. */
	struct iw_public_data *	wireless_data;
#endif

There is no dependency on mac80211 but on WIRELESS_EXT.
That is a config option most other drivers select, so you best change your patch to
	select WIRELESS_EXT
instead of MAC80211.

Ivo

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Sebastian Siewior]

* Ivo van Doorn | 2008-02-23 20:44:59 [+0100]:

>Is there any particular reason why this driver is in drivers/net instead
>of drivers/net/wireless (along with all other wireless drivers?

My understanding is/was that the wireless device and the eth device are
exposed by the hypervisor to the system and they share ressources.

Sebastian

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Ivo van Doorn]

On Saturday 23 February 2008, Sebastian Siewior wrote:
> * Ivo van Doorn | 2008-02-23 20:44:59 [+0100]:
> 
> >Is there any particular reason why this driver is in drivers/net instead
> >of drivers/net/wireless (along with all other wireless drivers?
> 
> My understanding is/was that the wireless device and the eth device are
> exposed by the hypervisor to the system and they share ressources.

Ah ok, makes sense. :)

Thanks.

Ivo

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Jeff Garzik]

Sebastian Siewior wrote:
> so select it.
> Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>
> ---
>  drivers/net/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f337800..a116056 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2363,6 +2363,7 @@ config GELIC_NET
>  config GELIC_WIRELESS
>         bool "PS3 Wireless support"
>         depends on GELIC_NET
> +       select MAC80211

Given that this is straying clearly into wireless territory, I think the 
linux-wireless folks and John Linville (wireless maintainer) are 
appropriate patch targets.

	Jeff

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Sebastian Siewior]

* Jeff Garzik | 2008-02-23 15:26:07 [-0500]:

> Given that this is straying clearly into wireless territory, I think the 
> linux-wireless folks and John Linville (wireless maintainer) are 
> appropriate patch targets.
Okey, I'm going to forward the pach.

> 	Jeff

Sebastian

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]


On Sat, 2008-02-23 at 15:26 -0500, Jeff Garzik wrote:
> Sebastian Siewior wrote:
> > so select it.
> > Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>
> > ---
> >  drivers/net/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index f337800..a116056 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -2363,6 +2363,7 @@ config GELIC_NET
> >  config GELIC_WIRELESS
> >         bool "PS3 Wireless support"
> >         depends on GELIC_NET
> > +       select MAC80211

That seems completely wrong since it's a full-mac "chip" (implemented in
the HV or so maybe). What exactly does it need from mac80211?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Sebastian Siewior]

* Johannes Berg | 2008-02-25 11:13:56 [+0100]:

>That seems completely wrong since it's a full-mac "chip" (implemented in
>the HV or so maybe). What exactly does it need from mac80211?
Nothing, please drop. I've sent another patch which enables WEXT what is
the correct thing to do. Sorry for the noise.

>johannes

Sebastian

Re: [PATCH] [PS3] gelic wireless driver needs MAC80211 support

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]


On Mon, 2008-02-25 at 12:16 +0100, Sebastian Siewior wrote:
> * Johannes Berg | 2008-02-25 11:13:56 [+0100]:
> 
> >That seems completely wrong since it's a full-mac "chip" (implemented in
> >the HV or so maybe). What exactly does it need from mac80211?
> Nothing, please drop. I've sent another patch which enables WEXT what is
> the correct thing to do. Sorry for the noise.

No problem. I saw it later on netdev but had read linux-wireless
first :)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]