From: David Miller <davem@davemloft.net>
To: jwestfall@surrealistic.net
Cc: netdev@vger.kernel.org, acme@ghostprotocols.net
Subject: Re: [PATCH] llc: fix skb size for test responses
Date: Sun, 24 Feb 2008 18:51:04 -0800 (PST) [thread overview]
Message-ID: <20080224.185104.207884881.davem@davemloft.net> (raw)
In-Reply-To: <20080224190758.GW84358@surrealistic.net>
From: Jim Westfall <jwestfall@surrealistic.net>
Date: Sun, 24 Feb 2008 11:07:58 -0800
> Hi
>
> The llc test command is used for a layer2 ping and contains a variable
> length payload that we must include in the response. Use the size of the
> received skb as the size of the skb we must allocate to hold the payload.
>
> This resolved an skb_over_panic(), when trying to copy the payload into
> what was a hard coded skb of size 128.
>
> Signed-off-by: Jim Westfall <jwestfall@surrealistic.net>
Arnaldo, please review Jim's patch, thanks!
next prev parent reply other threads:[~2008-02-25 2:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 19:07 [PATCH] llc: fix skb size for test responses Jim Westfall
2008-02-25 2:51 ` David Miller [this message]
2008-02-25 5:04 ` Jim Westfall
2008-02-25 8:30 ` Joonwoo Park
2008-02-25 14:06 ` Arnaldo Carvalho de Melo
2008-02-25 19:47 ` David Miller
2008-02-26 7:00 ` Joonwoo Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080224.185104.207884881.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@ghostprotocols.net \
--cc=jwestfall@surrealistic.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).