* [PATCH] Fix multicast on VLAN interfaces
@ 2008-02-21 22:05 Phil Oester
2008-02-22 12:25 ` Patrick McHardy
2008-02-24 4:00 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Phil Oester @ 2008-02-21 22:05 UTC (permalink / raw)
To: netdev; +Cc: kaber
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
In commit 56addd6eeeb4e11f5a0af7093ca078e0f29140e0 the VLAN multicast list
handling was reworked. Unfortunately, a variable initialization was missed,
and multicast over vlan devices has been broken since 2.6.23-rc1 (apparently
not too many people use this). Trivial fix below, which might be a candidate
for -stable.
Phil
Signed-off-by: Phil Oester <kernel@linuxace.com>
[-- Attachment #2: patch-mcast-vlan --]
[-- Type: text/plain, Size: 371 bytes --]
diff --git a/net/core/dev.c b/net/core/dev.c
index 908f07c..999af2e 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2905,6 +2905,7 @@ int __dev_addr_add(struct dev_addr_list **list, int *count,
return -ENOMEM;
memcpy(da->da_addr, addr, alen);
da->da_addrlen = alen;
+ da->da_synced = 0;
da->da_users = 1;
da->da_gusers = glbl ? 1 : 0;
da->next = *list;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix multicast on VLAN interfaces
2008-02-21 22:05 [PATCH] Fix multicast on VLAN interfaces Phil Oester
@ 2008-02-22 12:25 ` Patrick McHardy
2008-02-24 4:00 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Patrick McHardy @ 2008-02-22 12:25 UTC (permalink / raw)
To: Phil Oester; +Cc: netdev
Phil Oester wrote:
> In commit 56addd6eeeb4e11f5a0af7093ca078e0f29140e0 the VLAN multicast list
> handling was reworked. Unfortunately, a variable initialization was missed,
> and multicast over vlan devices has been broken since 2.6.23-rc1 (apparently
> not too many people use this). Trivial fix below, which might be a candidate
> for -stable.
Thanks Phil, a similar patch is already sitting in net-2.6.git.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix multicast on VLAN interfaces
2008-02-21 22:05 [PATCH] Fix multicast on VLAN interfaces Phil Oester
2008-02-22 12:25 ` Patrick McHardy
@ 2008-02-24 4:00 ` David Miller
2008-02-24 6:32 ` Phil Oester
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2008-02-24 4:00 UTC (permalink / raw)
To: kernel; +Cc: netdev, kaber
From: Phil Oester <kernel@linuxace.com>
Date: Thu, 21 Feb 2008 14:05:42 -0800
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 908f07c..999af2e 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2905,6 +2905,7 @@ int __dev_addr_add(struct dev_addr_list **list, int *count,
> return -ENOMEM;
> memcpy(da->da_addr, addr, alen);
> da->da_addrlen = alen;
> + da->da_synced = 0;
> da->da_users = 1;
> da->da_gusers = glbl ? 1 : 0;
> da->next = *list;
"da" is kzalloc()'d, how can da->da_synced not be zero?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix multicast on VLAN interfaces
2008-02-24 4:00 ` David Miller
@ 2008-02-24 6:32 ` Phil Oester
0 siblings, 0 replies; 4+ messages in thread
From: Phil Oester @ 2008-02-24 6:32 UTC (permalink / raw)
To: David Miller; +Cc: netdev, kaber
On Sat, Feb 23, 2008 at 08:00:18PM -0800, David Miller wrote:
> "da" is kzalloc()'d, how can da->da_synced not be zero?
Because it was originally kmalloc'd, not kzalloc'd. It was
fixed about 2 days prior to my patch submission, here:
http://marc.info/?l=linux-netdev&m=120343348811767&w=2
which I missed.
Phil
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-02-24 6:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-21 22:05 [PATCH] Fix multicast on VLAN interfaces Phil Oester
2008-02-22 12:25 ` Patrick McHardy
2008-02-24 4:00 ` David Miller
2008-02-24 6:32 ` Phil Oester
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).