From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: New sparse warning in net/mac80211/debugfs_sta.c Date: Mon, 25 Feb 2008 12:14:34 -0800 (PST) Message-ID: <20080225.121434.59949449.davem@davemloft.net> References: <20080225.115220.02432174.davem@davemloft.net> <1203969403.13162.147.camel@johannes.berg> <1203969942.13162.151.camel@johannes.berg> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kaber@trash.net, joe@perches.com, harvey.harrison@gmail.com, netdev@vger.kernel.org To: johannes@sipsolutions.net Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:39750 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756057AbYBYUNv (ORCPT ); Mon, 25 Feb 2008 15:13:51 -0500 In-Reply-To: <1203969942.13162.151.camel@johannes.berg> Sender: netdev-owner@vger.kernel.org List-ID: From: Johannes Berg Date: Mon, 25 Feb 2008 21:05:42 +0100 > > On Mon, 2008-02-25 at 20:56 +0100, Johannes Berg wrote: > > On Mon, 2008-02-25 at 11:52 -0800, David Miller wrote: > > > From: Johannes Berg > > > Date: Mon, 25 Feb 2008 10:53:48 +0100 > > > > > > > Maybe we should just add a new printf modifier like %M for MAC > > > > addresses? Then we could use sprintf, snprintf, printk and whatever we > > > > please without any of the macro stuff... > > > > > > But GCC has no idea what the heck it is and will warn. > > > > No, I actually wondered about that too and finally just tried, it simply > > ignores it when doing the printf warnings. > > Wait, no, you're right, I had the wrong warning flags enabled :( Oh well :-/ I really think it's not worth dorking around with this print_mac() stuff so much like this, let's just take care of the cases that Patrick mentioned (which need to go back to MAC_FMT because they are in fast paths) and then leave this alone for a while. We've already wasted too much time on this. Thanks.