netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Jim Westfall <jwestfall@surrealistic.net>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] llc: fix skb size for test responses
Date: Mon, 25 Feb 2008 11:06:52 -0300	[thread overview]
Message-ID: <20080225140652.GC4022@ghostprotocols.net> (raw)
In-Reply-To: <20080225050421.GY84358@surrealistic.net>

Em Sun, Feb 24, 2008 at 09:04:21PM -0800, Jim Westfall escreveu:
> David Miller <davem@davemloft.net> wrote [02.24.08]:
> > From: Jim Westfall <jwestfall@surrealistic.net>
> > Date: Sun, 24 Feb 2008 11:07:58 -0800
> > 
> > > Hi
> > > 
> > > The llc test command is used for a layer2 ping and contains a variable 
> > > length payload that we must include in the response.  Use the size of the 
> > > received skb as the size of the skb we must allocate to hold the payload. 
> > > 
> > > This resolved an skb_over_panic(), when trying to copy the payload into 
> > > what was a hard coded skb of size 128.
> > > 
> > > Signed-off-by: Jim Westfall <jwestfall@surrealistic.net>
> > 
> > Arnaldo, please review Jim's patch, thanks!
> 
> Our of curiosity did you all get my 2nd patch?  
> 
> Subject: [PATCH] llc: dont trust payload size on test cmd
> 
> I sent it a few minutes after this one, but seems like it never made it 
> to the list.  My local smtp shows it was delivered sucussfully to 
> vger.kernel.org.

I got it, but you made a mistake on the To: address:

From: Jim Westfall <jwestfall@surrealistic.net>
Subject: [PATCH] llc: dont trust payload size on test cmd
To: "To:netdev"@vger.kernel.org, acme@ghostprotocols.net

  parent reply	other threads:[~2008-02-25 14:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-24 19:07 [PATCH] llc: fix skb size for test responses Jim Westfall
2008-02-25  2:51 ` David Miller
2008-02-25  5:04   ` Jim Westfall
2008-02-25  8:30     ` Joonwoo Park
2008-02-25 14:06     ` Arnaldo Carvalho de Melo [this message]
2008-02-25 19:47     ` David Miller
2008-02-26  7:00 ` Joonwoo Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080225140652.GC4022@ghostprotocols.net \
    --to=acme@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jwestfall@surrealistic.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).