From: Sam Ravnborg <sam@ravnborg.org>
To: David Brownell <david-b@pacbell.net>
Cc: nico@cam.org, netdev@vger.kernel.org
Subject: Re: [patch 2.6.25-rc3] smc91x section fix
Date: Mon, 25 Feb 2008 21:11:12 +0100 [thread overview]
Message-ID: <20080225201112.GA23667@uranus.ravnborg.org> (raw)
In-Reply-To: <200802242233.12764.david-b@pacbell.net>
On Sun, Feb 24, 2008 at 10:33:12PM -0800, David Brownell wrote:
> On Sunday 24 February 2008, Sam Ravnborg wrote:
>
> > From a quick look this is wrong.
> > smc_drv_probe is assined the .probe member so it is used during
> > hotplug and thus should be __devinit.
> > Likewise smc_probe is used by smc_drv_probe and thus smc_probe
> > should be __devinit too.
>
> Thing is, with only rare exceptions, devices on the platform
> bus are *NOT* hotpluggable. So using __devinit/__devexit and
> friends adds up to no more than a waste of I-space.
It was a quick look - thanks for the explanation.
Sam
next prev parent reply other threads:[~2008-02-25 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 3:34 [patch 2.6.25-rc3] smc91x section fix David Brownell
2008-02-25 6:02 ` Sam Ravnborg
2008-02-25 6:33 ` David Brownell
2008-02-25 20:11 ` Sam Ravnborg [this message]
2008-04-19 3:01 ` [RESEND/UPDATED patch 2.6.25] " David Brownell
2008-04-25 6:02 ` Jeff Garzik
2008-07-25 20:11 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080225201112.GA23667@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=david-b@pacbell.net \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).