Netdev List
 help / color / mirror / Atom feed
From: Joakim Koskela <joakim.koskela@hiit.fi>
To: netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] [XFRM] Beet: Fix output for ipv6
Date: Mon, 25 Feb 2008 22:31:00 +0200	[thread overview]
Message-ID: <200802252231.01021.joakim.koskela@hiit.fi> (raw)
In-Reply-To: <200802081812.18985.joakim.koskela@hiit.fi>

Hi Herbert, 

Have you had a chance to look this, or are you working on something else for 
it?

On Friday 08 February 2008 18:12, Joakim Koskela wrote:
> Hi,
>
> This patch fixes the ipv6 mode of ipsec beet. It has been using logic
> similar to tunnel mode, making it crash during esp packaging.
>
> Signed-off-by: Joakim Koskela <jookos@gmail.com>
> ---
>  net/ipv6/xfrm6_mode_beet.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv6/xfrm6_mode_beet.c b/net/ipv6/xfrm6_mode_beet.c
> index 0527d11..0395800 100644
> --- a/net/ipv6/xfrm6_mode_beet.c
> +++ b/net/ipv6/xfrm6_mode_beet.c
> @@ -40,11 +40,14 @@ static void xfrm6_beet_make_header(struct sk_buff *skb)
>  static int xfrm6_beet_output(struct xfrm_state *x, struct sk_buff *skb)
>  {
>  	struct ipv6hdr *top_iph;
> +	u8 *prevhdr;
> +	int hdr_len;
>
> +	hdr_len = x->type->hdr_offset(x, skb, &prevhdr);
> +	skb_set_mac_header(skb, (prevhdr - x->props.header_len) - skb->data);
>  	skb_set_network_header(skb, -x->props.header_len);
> -	skb->mac_header = skb->network_header +
> -			  offsetof(struct ipv6hdr, nexthdr);
> -	skb->transport_header = skb->network_header + sizeof(*top_iph);
> +	skb->transport_header = skb->network_header + hdr_len;
> +	__skb_pull(skb, hdr_len);
>
>  	xfrm6_beet_make_header(skb);
>


  reply	other threads:[~2008-02-25 20:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 16:12 [PATCH] [XFRM] Beet: Fix output for ipv6 Joakim Koskela
2008-02-25 20:31 ` Joakim Koskela [this message]
2008-03-06 11:08   ` Herbert Xu
2008-03-07 17:22     ` Joakim Koskela
2008-03-26 13:30       ` Herbert Xu
2008-03-26 23:51         ` David Miller
2008-03-07 17:52     ` [RFC PATCH]: Fix output for BEET ipsec Joakim Koskela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802252231.01021.joakim.koskela@hiit.fi \
    --to=joakim.koskela@hiit.fi \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox