From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: davej@codemonkey.org.uk, netdev@vger.kernel.org
Subject: Re: lockdep trace from rc2.
Date: Tue, 26 Feb 2008 22:40:10 -0800 (PST) [thread overview]
Message-ID: <20080226.224010.227576469.davem@davemloft.net> (raw)
In-Reply-To: <20080226195400.3f6e010b@extreme>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 26 Feb 2008 19:54:00 -0800
> > This has come up before in other drivers,
> > you can't call flush_scheduled_work under RTNL.
>
> Correct link: http://kerneltrap.org/mailarchive/linux-kernel/2007/4/11/76312
Ok.
When I first looked at Dave's lockdep trace I grepped around and there
are a bunch of drivers that call flush_scheduled_work like this.
It seems that the common case is a driver that shares a lot of code
between the suspend and ->stop paths. Tulip is just such a case.
I can't tell if it's legal to just move the flush_scheduled_work()
call out of tulip_down() and into it's suspend function. If it
needs this for suspend it probably needs it for ->stop() too.
Maybe it could do something similar to the 8139too fix at the above
URL, but this is quite cumbersome if you ask me.
Anyways, could someone please work on a fix for this stuff?
next prev parent reply other threads:[~2008-02-27 6:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 2:22 lockdep trace from rc2 Dave Jones
2008-02-25 10:46 ` Johannes Berg
2008-02-27 11:44 ` Johannes Berg
2008-02-27 2:13 ` David Miller
2008-02-27 3:51 ` Stephen Hemminger
2008-02-27 3:54 ` Stephen Hemminger
2008-02-27 6:40 ` David Miller [this message]
2008-02-27 11:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226.224010.227576469.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@codemonkey.org.uk \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).