From: Grant Grundler <grundler@parisc-linux.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
Ondrej Zary <linux@rainbow-software.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x
Date: Tue, 26 Feb 2008 00:48:19 -0700 [thread overview]
Message-ID: <20080226074819.GA27484@colo.lackof.org> (raw)
In-Reply-To: <47C26E78.1040103@pobox.com>
On Mon, Feb 25, 2008 at 02:30:00AM -0500, Jeff Garzik wrote:
> Grant Grundler wrote:
>> On Mon, Feb 18, 2008 at 05:40:42PM +0100, Ondrej Zary wrote:
>>> I think that de2104x driver should be removed (or at least its
>>> MODULE_DEVICE_TABLE) and MODULE_DEVICE_TABLE with only 21040 and 21041
>>> PCI IDs added to de4x5.
>>>
>>> I can send a patch if this is acceptable.
>> It's acceptable to me. Jeff? (jgarzik)
>
> NAK, sorry, for two reasons:
>
> 1) we don't delete otherwise clean, working drivers
Just to be clear - he's not trying to remove the driver.
He's just interested in making de4x5 the "default" for this set of boards
by doctoring with the pci device ids each driver will claim.
> simply because of a bug triggered by unplugging a cable.
Ondrej would be happy to test any patches sent. Tracking this sort
of bug down usually isn't trivial as the statement above implies.
> 2) de4x5 needs to go away.
Ok. I'd prefer to wait until someone demonstrates de2104x driver is a fully
functional alternative for all the PCI Ids it claims.
thanks,
grant
next prev parent reply other threads:[~2008-02-26 7:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 20:58 Compex FreedomLine 32 PnP-PCI2 broken with de2104x Ondrej Zary
2008-01-30 20:23 ` Ondrej Zary
2008-02-18 3:21 ` Grant Grundler
2008-02-18 16:40 ` Ondrej Zary
2008-02-25 7:15 ` Grant Grundler
2008-02-25 7:30 ` Jeff Garzik
2008-02-26 7:48 ` Grant Grundler [this message]
2008-02-25 17:45 ` [PATCH] de2104x: remove BUG_ON() when changing media type Ondrej Zary
2008-02-25 17:52 ` Jeff Garzik
2008-03-24 2:45 ` Grant Grundler
2008-03-24 23:02 ` Ondrej Zary
2008-03-26 15:59 ` Grant Grundler
2008-03-26 18:29 ` Ondrej Zary
2008-03-05 11:27 ` Jeff Garzik
2008-02-25 7:28 ` Compex FreedomLine 32 PnP-PCI2 broken with de2104x Jeff Garzik
2008-02-25 21:31 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226074819.GA27484@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).